Use DSP library from main GUI instead of a common library plugin#296
Merged
aacuevas merged 3 commits intoopen-ephys:developmentfrom May 5, 2019
Merged
Use DSP library from main GUI instead of a common library plugin#296aacuevas merged 3 commits intoopen-ephys:developmentfrom
aacuevas merged 3 commits intoopen-ephys:developmentfrom
Conversation
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #295. Just deletes the
DspLibplugin, adds a header to import the DSP library from the main GUI andPLUGIN_APIdeclarations for Windows, and updates build files.I don't have a Mac, so someone should verify that the modified OSX build files are correct. I just deleted files specific to
DspLib, and then went through general andFilterNodefiles and deleted any references to it (comparing with theRectifierproject files for reference).