Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commits fix all the warnings that are shown during compiling (tested only in Linux).
warning: invalid use of incomplete type ‘class juce::LookAndFeel’ getLookAndFeel().drawLasso (g, *this);
was fixed followinf latest JUCE library versiob
https://github.com/WeAreROLI/JUCE/blob/cabcbde0e2ed17cb98299f04b91f7af19f86b6f5/modules/juce_gui_basics/juce_gui_basics.h#L298
warning: ‘template class std::auto_ptr’ is deprecated [-Wdeprecated-declarations]
typedef std::auto_ptrOpalKellyLegacy::okCFrontPanel FrontPanelPtr;
was fixed following
https://stackoverflow.com/questions/45053626/error-templateclass-class-stdauto-ptr-is-deprecated
auto_ptr -> unique_ptr
warning: ‘void juce::Button::setToggleState(bool, bool)’ is deprecated [-Wdeprecated-declarations]
b->setToggleState(true, false);
was fixed using the note
https://github.com/yagui/plugin-GUI/blob/56aa112f8b6160b7cf184b280cf2c3d338441fc9/JuceLibraryCode/modules/juce_gui_basics/buttons/juce_Button.h#L349
The new version is
https://github.com/yagui/plugin-GUI/blob/56aa112f8b6160b7cf184b280cf2c3d338441fc9/JuceLibraryCode/modules/juce_gui_basics/buttons/juce_Button.h#L95
Should be NotificationType instead of bool.
I asume that 'false' should be juce::NotificationType::dontSendNotification
Not sure if that is the right choice
(This one is not present anymore)
warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated] throw(SocketException)
was fixed following
https://docs.microsoft.com/en-us/cpp/cpp/exception-specifications-throw-cpp?view=vs-2019
throw() -> noexcept(true)
throw(type) -> noexcept(false)