Skip to content

Warnings fixs#299

Merged
aacuevas merged 2 commits intoopen-ephys:developmentfrom
yagui:warnings
Aug 24, 2019
Merged

Warnings fixs#299
aacuevas merged 2 commits intoopen-ephys:developmentfrom
yagui:warnings

Conversation

@yagui
Copy link
Copy Markdown
Contributor

@yagui yagui commented May 21, 2019

This commits fix all the warnings that are shown during compiling (tested only in Linux).

  • Warnings in juce_LassoComponent.h
    warning: invalid use of incomplete type ‘class juce::LookAndFeel’ getLookAndFeel().drawLasso (g, *this);

was fixed followinf latest JUCE library versiob
https://github.com/WeAreROLI/JUCE/blob/cabcbde0e2ed17cb98299f04b91f7af19f86b6f5/modules/juce_gui_basics/juce_gui_basics.h#L298

  • Warnings in okFrontPanelDLL.h
    warning: ‘template class std::auto_ptr’ is deprecated [-Wdeprecated-declarations]
    typedef std::auto_ptrOpalKellyLegacy::okCFrontPanel FrontPanelPtr;

was fixed following
https://stackoverflow.com/questions/45053626/error-templateclass-class-stdauto-ptr-is-deprecated
auto_ptr -> unique_ptr

  • Warning in EngineConfigWindow.cpp
    warning: ‘void juce::Button::setToggleState(bool, bool)’ is deprecated [-Wdeprecated-declarations]
    b->setToggleState(true, false);

was fixed using the note
https://github.com/yagui/plugin-GUI/blob/56aa112f8b6160b7cf184b280cf2c3d338441fc9/JuceLibraryCode/modules/juce_gui_basics/buttons/juce_Button.h#L349

The new version is
https://github.com/yagui/plugin-GUI/blob/56aa112f8b6160b7cf184b280cf2c3d338441fc9/JuceLibraryCode/modules/juce_gui_basics/buttons/juce_Button.h#L95

Should be NotificationType instead of bool.
I asume that 'false' should be juce::NotificationType::dontSendNotification
Not sure if that is the right choice

(This one is not present anymore)

  • Warnings in PracticalSocket cpp/h
    warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated] throw(SocketException)

was fixed following
https://docs.microsoft.com/en-us/cpp/cpp/exception-specifications-throw-cpp?view=vs-2019
throw() -> noexcept(true)
throw(type) -> noexcept(false)

@aacuevas aacuevas merged commit f918eb9 into open-ephys:development Aug 24, 2019
@yagui yagui deleted the warnings branch August 29, 2019 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants