Fix uninitialized use of numChannels in GenericEditor.cpp#309
Merged
aacuevas merged 1 commit intoopen-ephys:developmentfrom Aug 23, 2019
Merged
Fix uninitialized use of numChannels in GenericEditor.cpp#309aacuevas merged 1 commit intoopen-ephys:developmentfrom
aacuevas merged 1 commit intoopen-ephys:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tiny issue that I'm not sure why I haven't seen before.... There's a use of a local variable
numChannelsbefore it is initialized for processors that do not have achannelSelector, i.e. utilities. When I was running in debug mode and this happened, Windows gave me an error with a big red X saying this was a Bad Thing. Even though in this case I don't think it matters, it's good practice not to read uninitialized variables and I appreciate the strictness.