Skip to content

Update HTTP directory field#514

Merged
jsiegle merged 2 commits intoopen-ephys:development-juce6from
bjhardcastle:development-juce6
Jun 29, 2022
Merged

Update HTTP directory field#514
jsiegle merged 2 commits intoopen-ephys:development-juce6from
bjhardcastle:development-juce6

Conversation

@bjhardcastle
Copy link
Copy Markdown
Contributor

base_text looks like the correct var name

current_directory_name appears unused

Fix directory naming via HTTPServer · open-ephys/plugin-GUI@626f50d · GitHub

@jsiegle
Copy link
Copy Markdown
Member

jsiegle commented Jun 28, 2022

Hi @bjhardcastle ...thanks for submitting this fix. I think we actually need to add a new CoreServices method called getRecordingDirectoryBaseText(), and have this be what gets returned in the base_text field. That way you can validate whether the requested changes to the base text took effect, while also seeing the current recording directory name (which may be auto-generated). Would that solve the issue?

@bjhardcastle
Copy link
Copy Markdown
Contributor Author

Hi Josh/Pavel,
This looks perfect - thank you for implementing the changes already.
I might attempt to rebuild and start using it this week, but setting the name in "open-loop" without validation is working fine for now.
Thanks!

@jsiegle jsiegle merged commit 9ed8339 into open-ephys:development-juce6 Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants