feat: Base data structures fot hook implementation.#112
feat: Base data structures fot hook implementation.#112NeaguGeorgiana23 wants to merge 6 commits into
Conversation
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
|
Warning Review limit reached
Next review available in: 56 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds the ChangesNew Type Definitions
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
There was a problem hiding this comment.
Pull request overview
Adds foundational public types to support a future Hooks implementation in the OpenFeature C++ SDK, aligning with Issue #111’s “Hook hints” portion and preparing for later HookData/EvaluationOptions work.
Changes:
- Introduces
HookHintsas astd::unordered_map<std::string, std::any>type alias. - Introduces
FlagValueTypeenum to represent supported flag value categories.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| openfeature/hook_hints.h | Adds the HookHints type alias for passing arbitrary hook hint data. |
| openfeature/flag_type_value.h | Adds the FlagValueType enum for flag value categorization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }; | ||
|
|
||
| } // namespace openfeature | ||
| #endif // CPP_SDK_INCLUDE_OPENFEATURE_FLAG_VALUE_TYPE_H_ No newline at end of file |
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
This PR
Introduces HookHints and FlagTypeValus that will allow later implementation of Hooks.
Related Issues
Fixes #111
Follow-up Tasks
Implementing the EvaluationOptions and HookData.