chore: exclude component in git tag#190
Merged
Merged
Conversation
This change prevents Release Please from adding the component name in the release tag. It looks like currently that's not a problem but this will prevent it from happening if the component name detection changes in the future. Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Member
|
Just for posterity can you give an example? |
Member
Here's a release that has a component name in Java: https://github.com/open-feature/java-sdk/releases/tag/dev.openfeature.javasdk-v0.2.2 Instead of the tag just being |
toddbaert
approved these changes
Oct 12, 2022
AlexsJones
approved these changes
Oct 12, 2022
raphael-wigoutschnigg-dt
pushed a commit
to open-feature-forking/flagd
that referenced
this pull request
Mar 11, 2025
… v1.10.1 (open-feature#190) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change prevents Release Please from adding the component name in the release tag. It looks like currently that's not a problem but this will prevent it from happening if the component name detection changes in the future.
Signed-off-by: Michael Beemer beeme1mr@users.noreply.github.com