fix: include types in exports #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #355 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 15 15
Lines 1236 1236
Branches 97 97
=======================================
Hits 1232 1232
Misses 4 4 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Member
Author
|
Documentation around dual CommonJS/ES modules: |
toddbaert
approved these changes
Dec 23, 2022
Member
toddbaert
left a comment
toddbaert
left a comment
There was a problem hiding this comment.
Documentation around dual CommonJS/ES modules: https://nodejs.org/api/packages.html#dual-commonjses-module-packages
This is pretty disappointing, but at least it's documented.
lukas-reining
pushed a commit
that referenced
this pull request
Jun 29, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
beeme1mr
deleted the
354-bug-typescript-doesnt-find-the-included-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #354
Notes
Thanks for reporting the bug @talzion12
Signed-off-by: Michael Beemer beeme1mr@users.noreply.github.com