Skip to content

chore: replace black, flake8 and isort with ruff and ruff-format#30

Merged
beeme1mr merged 3 commits intoopen-feature:mainfrom
gruebel:add-ruff
Jan 9, 2024
Merged

chore: replace black, flake8 and isort with ruff and ruff-format#30
beeme1mr merged 3 commits intoopen-feature:mainfrom
gruebel:add-ruff

Conversation

@gruebel
Copy link
Copy Markdown
Member

@gruebel gruebel commented Jan 9, 2024

This PR

same as in open-feature/python-sdk#249

  • merged both workflows merge.yml and pullrequest.yml into build.yml, like in the python-sdk project, they were almost identical, just the trigger was different
  • also migrated from container based builds to the normal host ones by leveraging setup-python GHA, same as in the python-sdk project

Signed-off-by: gruebel <anton.gruebel@gmail.com>
Signed-off-by: gruebel <anton.gruebel@gmail.com>
Signed-off-by: gruebel <anton.gruebel@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (684a90a) 63.44% compared to head (fd02ae9) 85.12%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #30       +/-   ##
===========================================
+ Coverage   63.44%   85.12%   +21.67%     
===========================================
  Files           8        6        -2     
  Lines         238      121      -117     
===========================================
- Hits          151      103       -48     
+ Misses         87       18       -69     
Flag Coverage Δ
unittests 85.12% <ø> (+21.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-advanced-security
Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@beeme1mr
Copy link
Copy Markdown
Member

beeme1mr commented Jan 9, 2024

Did you intend to remove CodeQL?

@gruebel
Copy link
Copy Markdown
Member Author

gruebel commented Jan 9, 2024

@beeme1mr it is still there, previously named pullrequest.yml, now build.yml file. Just need to expand at the bottom of the file, tries to hide itself 😄

@beeme1mr
Copy link
Copy Markdown
Member

beeme1mr commented Jan 9, 2024

🤦 my bad... the change looks good.

@gruebel
Copy link
Copy Markdown
Member Author

gruebel commented Jan 9, 2024

@beeme1mr do you know what the required build (python:3.8) checks are? I don't see them anywhere defined, so not sure why they are hanging.

@beeme1mr beeme1mr closed this Jan 9, 2024
@beeme1mr beeme1mr reopened this Jan 9, 2024
@beeme1mr beeme1mr merged commit c5584ee into open-feature:main Jan 9, 2024
@beeme1mr
Copy link
Copy Markdown
Member

beeme1mr commented Jan 9, 2024

@beeme1mr do you know what the required build (python:3.8) checks are? I don't see them anywhere defined, so not sure why they are hanging.

The branch protection rules needed to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants