chore: replace black, fake8 and isort with ruff and ruff-format#249
chore: replace black, fake8 and isort with ruff and ruff-format#249beeme1mr merged 4 commits intoopen-feature:mainfrom
Conversation
Signed-off-by: gruebel <anton.gruebel@gmail.com>
|
hey @federicobond and @beeme1mr created a new PR, which only does the ruff addition. Will do the code adjustments in a follow-up PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
=======================================
Coverage 93.45% 93.45%
=======================================
Files 16 16
Lines 443 443
=======================================
Hits 414 414
Misses 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: gruebel <anton.gruebel@gmail.com>
Signed-off-by: Anton Grübel <anton.gruebel@gmail.com>
|
Hey @gruebel, sorry for the delay here. Most of the team was out for the holidays. Things should speed up now that people are coming back 😄 |
Signed-off-by: gruebel <anton.gruebel@gmail.com>
|
@beeme1mr no problem 😄 Fixed the issue with the missing GHA version tag. It looks like they don't offer a shortened variant for it. I usually use commit hashes to pin all GHA versions. Are you interested in it or you want to keep it as is? |
I have a slight preference for version tags because they're easier to understand at a glance but I would be fine with either approach. |
All good, then let's keep as it is 🙂 |
|
I'll give @federicobond more time since he's our resident Python expert 😄 |
|
Sorry for the delay! I think this is good to merge. It's hard to understand all the implications of moving to a new set of style rules, but this moves us in the right direction regarding tooling, and if it turns out we need to fine-tune the config we can adjust it later. |
…1.10 (open-feature#249) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This PR
black,flake8andisortwithruffandruff-formatflake8and the plugins you mentioned in thepre-commitconfigpre-commitaction insteadRelated Issues
Fixes #219
Notes
Follow-up Tasks
How to test