Fix dotnet-ci tool name check to match OpenLobotomy.Tooling package - #12
Merged
Conversation
The tool name check grepped for 'dotnet-ci' but the published package is 'OpenLobotomy.Tooling' (normalized to 'openlobotomy.tooling' in dotnet tool list output). Consumer repos would fail the check even when the correct tool was installed.
There was a problem hiding this comment.
Pull request overview
This PR updates the org-level reusable .NET CI workflow so its local-tool-manifest validation matches the actual published tooling package (OpenLobotomy.Tooling), preventing consumer repositories from failing CI due to an incorrect package-id check.
Changes:
- Updates the manifest presence error message to reference
OpenLobotomy.Tooling. - Changes the
dotnet tool list --localvalidation fromdotnet-citoopenlobotomy.tooling.
dotnet tool install without a scope flag is ambiguous and can install globally; the workflow validates a local manifest, so the remediation text should direct users to install locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dotnet-ci.yml— it grepped for package iddotnet-ci, but the published package isOpenLobotomy.Tooling(normalized toopenlobotomy.toolingindotnet tool listoutput)Test plan