Implementation of Adding Status and Reviewers to assets - #22904
Merged
Conversation
yan-3005
added
the
safe to test
Contributor
|
TypeScript types have been updated based on the JSON schema changes in the PR |
…e same status enums, changed the logic to be APPROVED instead of Active, DataContract can have null status as seen in tests, Changed Workflow to use workflowStatus instead of status as it is contradicting with the approval status, Fixed Tests
# Conflicts: # openmetadata-service/src/test/java/org/openmetadata/service/resources/data/DataContractResourceTest.java
Contributor
|
The Java checkstyle failed. Please run You can install the pre-commit hooks with |
mohityadav766
requested changes
Sep 1, 2025
mohityadav766
left a comment
mohityadav766
left a comment
Member
There was a problem hiding this comment.
Some minor nits, also please make sure to test migrations towards entityStatus from lower version
# Conflicts: # openmetadata-service/src/test/java/org/openmetadata/service/resources/domains/DataProductResourceTest.java
…o feature/add-status-reviewer
|
|
mohityadav766
approved these changes
Sep 2, 2025
ShaileshParmar11
approved these changes
Sep 3, 2025
pmbrull
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes:
This is needed for Custom Workflows
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>