Skip to content

Backport database, schema, and container lazy-loading updates to 1.13#30132

Open
shah-harshit wants to merge 1 commit into
ui/backport-group12-common-pages-settings-lazy-1.13from
ui/backport-group13-database-schema-container-lazy-1.13
Open

Backport database, schema, and container lazy-loading updates to 1.13#30132
shah-harshit wants to merge 1 commit into
ui/backport-group12-common-pages-settings-lazy-1.13from
ui/backport-group13-database-schema-container-lazy-1.13

Conversation

@shah-harshit

@shah-harshit shah-harshit commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Stack

Testing

  • Scoped UI checkstyle sequence on changed source files: organize-imports-cli, ESLint --fix, Prettier.
  • git diff --check HEAD~1..HEAD

Greptile Summary

This PR moves database, schema, container, and version code onto lightweight utility modules. The main changes are:

  • Direct imports from pure container, table, search, summary, and version utilities.
  • Removal of obsolete container utility re-exports.
  • Updated test mocks for several relocated helpers.
  • Type-only handling for the profiler status-count type.

Confidence Score: 5/5

This looks safe to merge after a small test-mock cleanup.

  • The new production imports expose compatible symbols and lighter dependency surfaces.
  • Several version tests still mock the former utility path, reducing test isolation without changing production behavior.

Version tests whose components now import EntityVersionUtilsPure.

Important Files Changed

Filename Overview
openmetadata-ui/src/main/resources/ui/src/components/DriveService/Worksheet/WorksheetVersion/WorksheetVersion.tsx Moves version helpers to the pure module, but the matching test still mocks the former path.
openmetadata-ui/src/main/resources/ui/src/utils/ContainerDetailUtils.tsx Removes compatibility re-exports after production consumers moved to ContainerDetailPureUtils.
openmetadata-ui/src/main/resources/ui/src/utils/TablePureUtils.ts Uses compatible pure modules for API endpoint and container field extraction.
openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TableProfiler/TableProfilerProvider.tsx Separates the compile-time status-count type from the runtime aggregation import.

Reviews (1): Last reviewed commit: "feat(ui): update Database, Schema & Cont..." | Re-trigger Greptile

Greptile also left 1 inline comment on this PR.

Context used:

  • Context used - CLAUDE.md (source)
  • Context used - openmetadata-ui-core-components/CLAUDE.md (source)

…d utility pattern (#29067)

* feat(ui): update Database, Schema & Container components for lazy-load utility pattern

Updates Database, Schema, Container and DriveService components to import from extracted pure utility modules. Updates TablePureUtils, ContainerDetailUtils, ColumnUpdateUtils imports. Updates related pages for consistent utility usage.

Ref: open-metadata/openmetadata-collate#4230

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* address gitar-bot comments

* fix build

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
@shah-harshit
shah-harshit requested a review from a team as a code owner July 16, 2026 09:45
@shah-harshit shah-harshit added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check labels Jul 16, 2026
@shah-harshit shah-harshit self-assigned this Jul 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@gitar-bot

gitar-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Backports lazy-loading utility patterns for Database, Schema, and Container components to the 1.13 branch. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

getEntityVersionByField,
getEntityVersionTags,
} from '../../../../utils/EntityVersionUtils';
} from '../../../../utils/EntityVersionUtilsPure';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Version Helper Mocks No Longer Apply

This component now loads the helpers from EntityVersionUtilsPure, while WorksheetVersion.test.tsx still mocks EntityVersionUtils. The test therefore executes the real helpers instead of its stubs, so fixture changes can produce unrelated failures or let the test pass without exercising the intended mocked states. The version tests for the other import migrations in this PR need the same mock-path update.

Context Used: CLAUDE.md (source)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant