fix(ui): support explicit extension summary layouts#30245
Open
shah-harshit wants to merge 4 commits into
Open
Conversation
shah-harshit
added
UI
Contributor
🔴 Playwright Results — 1 test failure(s)✅ 4543 passed · ❌ 1 failed · 🟡 26 flaky · ⏭️ 99 skipped
Genuine Failures (failed on all attempts)❌
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Jest test CoverageUI tests summary
|
Code Review ✅ ApprovedImplements explicit summary layouts for product-specific entities via a new registry, ensuring these mapped extensions remain read-only while preserving original entity types for API operations. Comprehensive tests verify correct rendering and safety for both supported and unsupported entity types. OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|
harsh-vador
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Adds an explicit summary-layout extension point so product-specific entities can reuse an existing generic summary without changing their real entity type. Unknown entity types continue to render no summary content.
Type of change:
High-level design:
Tests:
Use cases covered
Unit tests
Backend integration tests
Ingestion integration tests
Playwright (UI) tests
Manual testing performed
UI screen recording / screenshots:
Not attached.
Checklist:
Summary by Gitar
summaryEntityTypetoDataAssetSummaryPanelV1to allow mapping extension entities to existing summary layouts.getEntitySummaryPanelTypeinSearchClassBaseto resolve summary layouts for product extensions.DataAssetSummaryPanelV1to enforce read-only state for mapped extension entities by disabling all edit permissions whensummaryEntityType !== entityType.DataAssetSummaryPanelV1.test.tsxto verify that unknown entity types render no summary sections and mapped extensions render correctly without edit actions.EntitySummaryPanel.test.tsxto ensure extensions fetch using their original entity type while resolving the correct summary layout.This will update automatically on new commits.
Greptile Summary
This PR adds explicit summary layouts for product-specific entity extensions. The main changes are:
SearchClassBase.Confidence Score: 5/5
This looks safe to merge.
Important Files Changed
Reviews (3): Last reviewed commit: "Merge branch 'main' into ui/fix-ai-dashb..." | Re-trigger Greptile
Context used (3)