fix(ui): drop redundant outer frame card on Domain & Data Product docs#30338
fix(ui): drop redundant outer frame card on Domain & Data Product docs#30338siddhant1 wants to merge 3 commits into
Conversation
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
siddhant1
added
UI
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Jest test CoverageUI tests summary
|
🔴 Playwright Results — 14 pipeline/setup failure(s)✅ 0 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped Pipeline and setup failures
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
The Documentation tab on Domain and Data Product detail pages renders the Description as the sole left-panel widget, so the standard left-panel frame card wrapped the Description's own card — a redundant double card with an uneven gap at the bottom. Add an opt-in `flat` variant to GenericTab that drops the left-panel frame (background / border / shadow) and its inner padding, leaving a single Description card flush-aligned with the tabs (left) and the right panel (top). Every other entity type is unchanged because the variant defaults to `default`, so pages whose left panel legitimately holds multiple sections keep their frame. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
cb22cb5 to
5b8a998
Compare
siddhant1
changed the title
|
siddhant1
added
safe to test
|
Superseded by #30450 — re-opened from a branch on |
Pull request was closed
Code Review ✅ Approved 1 resolved / 1 findingsRemoves the redundant outer frame card on Domain and Data Product documentation tabs by introducing an opt-in flat variant. Consider verifying whether updating the card's border-radius to rounded-xl unintentionally affects other entity types sharing the description component. ✅ 1 resolved✅ Quality: Border-radius change affects all entities' Description cards
OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
What
On the Documentation tab of Domain and Data Product detail pages, the Description now renders as a single, clean card — flush‑aligned with the tabs on the left and the right‑hand panel on top.
Previously the Description was wrapped in two nested cards: the standard left‑panel frame (its own background + border + shadow, plus a 16px inner padding) and the Description's own
wrapInCardbox. Because both pages place the Description as the sole child of the left panel, the frame just duplicated the card — a double border with an uneven gap at the bottom, and the inner card sat inset ~16px from everything around it.How
variantprop toGenericTab('default' | 'flat', defaults to'default').flatvariant drops the left‑panel frame (background: transparent; border: none; box-shadow: none) and zeroes the frame's inner padding, so the lone Description card lines up flush with the tabs (left) and the right panel (top) instead of being inset by the frame gap.<GenericTab … variant="flat" />.rounded-[10px]→rounded-xl) now that it's the only card and its corners are more visible.Every other entity type (Tables, Dashboards, etc.) is untouched — their left panel legitimately holds multiple sections (Description and Schema), so
variantdefaults to'default'and they keep the frame. Theflat-left-paneloverride is scoped to that class, which is only ever added on these two pages, so nothing else can regress.Before / After
Domain
Data Product
Testing
border: 0 / background: transparent / box-shadow: none.269px) now matches the tabs, and its top (400px) matches the right panel — vs. being offset by one@padding-md(16px) on both axes before.flat-left-panelclass is applied only whenvariant="flat", so no other entity type can regress.🤖 Generated with Claude Code
Greptile Summary
This PR simplifies the Documentation layout for Domain and Data Product pages. The main changes are:
flatvariant toGenericTab.rounded-xl.Confidence Score: 5/5
No additional blocking issue qualifies for this follow-up review.
Important Files Changed
Reviews (5): Last reviewed commit: "Merge branch 'main' into remove-descript..." | Re-trigger Greptile
Context used (3)