fix(playwright): green playwright-summary when gate skips the pipeline

[chirag-madlani]

Summary

Regression from #30453 that surfaced on PR #30454 (run 30090391086):

• `pull_request_target` fires on a same-repo PR
• `gate` correctly returns `should_run=false` (redundant — `pull_request` already handles it)
• Every upstream job is legitimately `skipped`
• But `playwright-summary` runs the render step unconditionally (`if: always()`)
• `render_playwright_summary.cjs` counts each skipped upstream as a "CI/reporting failure" and calls `core.setFailed()`
• The required `playwright-summary` check goes 🔴 with `0 Playwright test failure(s); 9 CI/reporting failure(s)`
• Branch protection blocks the PR, even though the sibling `pull_request` run passed

Fix

Three-line change on the `playwright-summary` job:

1. Add `gate` to its `needs:` list (so it can read `needs.gate.outputs.should_run`)
2. Gate the render step on `should_run == 'true'` — skips when gate said skip
3. Add a tiny "Report gate-skipped run as green" step with the opposite condition that echoes success — keeps the job's conclusion at ✅ so branch protection sees green regardless of which event fired

Behaviour matrix after this fix

Event	gate	render	job conclusion
merge_group / workflow_dispatch / schedule	true	run	real result
same-repo PR + pull_request	true	run	real result
same-repo PR + pull_request_target	false	skipped	✅ green (this fix)
fork PR + pull_request_target + label	true	run	real result
fork PR + pull_request_target, no label	false	skipped	✅ green (this fix)
fork PR + pull_request	false	skipped	✅ green (this fix)
any draft PR	false	skipped	✅ green (this fix)

Diff scope

```
.github/workflows/playwright-postgresql-e2e.yml | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
```

Pure workflow change. No script edits, no test edits, no logic changes to the render pathway.

Test plan

• Same-repo PR (this one): `pull_request` triggers, gate returns `true`, everything runs normally including render. `pull_request_target` triggers, gate returns `false`, render skips, "Report gate-skipped run as green" runs, job ✅.
• Fork PR without `safe to test`: both events fire, both gate to false, both skip render, both jobs ✅.
• Merge queue: gate=true, everything runs, render fires normally.

🤖 Generated with Claude Code

Greptile Summary

Adds explicit handling for every Playwright gate outcome.

• Fails the summary job when the gate does not complete successfully.
• Reports an explicit should_run=false decision as a successful intentional skip.
• Runs the consolidated summary renderer only for an explicit should_run=true decision.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failures remain.

Important Files Changed

Filename	Overview
.github/workflows/playwright-postgresql-e2e.yml	The summary job now distinguishes gate failures, explicit skips, and executable test runs without leaving the previously reported missing-output path green.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  G[Gate job completes] --> R{Gate result is success?}
  R -- No --> F[Fail summary job]
  R -- Yes --> D{should_run decision}
  D -- true --> P[Render consolidated Playwright summary]
  D -- false --> S[Report intentional skip as green]

Loading

_{Reviews (2): Last reviewed commit: "address greptile P1: fail if gate itself..." | Re-trigger Greptile}

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[github-actions]

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

• No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[chirag-madlani]

@greptile-apps thanks — addressed in 497d7d0b00.

Two changes on playwright-summary:

1. New "Guard against missing gate decision" step at the top of the job. Fails with exit 1 when needs.gate.result != 'success' — i.e., when gate crashed, was cancelled, or otherwise didn't produce a valid decision. Prevents the required check from ever reporting synthetic green on an invalid pipeline state.

2. Tightened the green-report condition from should_run != 'true' → should_run == 'false'. Now only an explicit skip decision falls through to the green path; an unset output would fail the guard above.

Behaviour matrix after this fix:

gate.result	should_run	guard	green-report	render	job
success	'true'	skip	skip	run	real result
success	'false'	skip	✅ green	skip	✅
success	(unset — shouldn't happen)	❌ fail	skip	skip	❌
failure	any	❌ fail	skip	skip	❌ (visible)
cancelled	any	❌ fail	skip	skip	❌ (visible)

[greptile-apps]

The fix in 497d7d0 correctly addresses the concern. The diff looks good:

1. Guard step (needs.gate.result != 'success') fails the job loudly when gate crashed or was cancelled — no silent synthetic green on an invalid pipeline state.
2. Green-report condition tightened to should_run == 'false' — an unset/null output can no longer fall through here, since the guard above would have already failed the job.
3. Render step unchanged at should_run == 'true' — only fires on an explicit affirmative decision.

The three conditions are mutually exhaustive for all valid gate states and correctly ordered so the guard always runs first. The original concern is fully resolved.

[gitar-bot]

Code Review ✅ Approved

Updates the Playwright E2E workflow to conditionally run the summary renderer only when the gate job outputs should_run equal to true, preventing false failures on skipped pipelines. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact

gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}