fix(ui): center domain/data-product list row items & fix DP detail header title width - #30510
fix(ui): center domain/data-product list row items & fix DP detail header title width#30510siddhant1 wants to merge 6 commits into
Conversation
The AI-mode Domain and Data Product list tables rendered their name cells with `<Box align="start">` (align-items: flex-start), pinning the icon + name to the top of the row instead of centering it — most visible when the name wraps to multiple lines. Use `align="center"` on the name/Domains cells so the icon lines up with the middle of the (single- or multi-line) name. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
🔴 Playwright Results — workflow failedValidated commit ✅ 0 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky Pipeline and setup failures (5)
Performance⚪ Performance metrics unavailable; see the CI and reporting failures above.
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
…adge is empty
DataProductsDetailsPage passed `badge={statusBadge}` to EntityHeader. A truthy
`badge` applies `w-max-full-200` (max-width: calc(100% - 200px)) to the title
column — reserving 200px even when EntityStatusBadge renders nothing (the common
`Unprocessed` status), which squeezed the title into a narrow box and forced
long names to wrap/break mid-word. The Domain header passes no badge and is
unaffected.
Move `statusBadge` into `suffix` (next to the LearningIcon): it still renders
inline when a status exists, but no longer reserves 200px, so the title uses its
natural width.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
e06ae1b to
f987b49
Compare
Code Review ✅ ApprovedVertically centers domain and data product list row items and updates the data product detail header layout to prevent empty status badges from restricting title width. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|



Two AI-mode UI fixes for the Domain & Data Product Marketplace pages.
1. List tables — vertically center row items
The Domain & Data Product list tables rendered their name cells with
<Box align="start">(→tw:items-start), pinning the icon + name to the top of the row instead of centering it. Nowalign="center".Files:
components/common/atoms/domain/ui/domainFieldRenderers.tsx,components/DataProduct/DataProductListPage.tsx.The shift shows when the row is taller than the name — i.e. a single-line name beside the icon, where it otherwise floats above the rest of the row. (A name long enough to wrap and fill the row height looks unchanged, so the demo below uses the Domains list, where
testis a single line:startpins it to the top,centeraligns it with the other cells.)align="start")align="center")2. Data Product detail header — don't reserve badge space when the status badge is empty
DataProductsDetailsPagepassedbadge={statusBadge}toEntityHeader. A truthybadgeappliesw-max-full-200(max-width: calc(100% - 200px)) to the title column — reserving 200px even when the status badge renders nothing (the commonUnprocessedstatus). That squeezed the title into a ~315px box and forced long names to wrap/break mid-word. The Domain header passes no badge, so it was unaffected (this was the "DP page looks wrong, Domain is fine" difference).Fix: move
statusBadgeintosuffix(next to the LearningIcon). It still renders inline when a status exists, but no longer reserves 200px, so the title uses its natural width.File:
components/DataProducts/DataProductsDetailsPage/DataProductsDetailsPage.component.tsx.🤖 Generated with Claude Code
Summary by Gitar
Reindexlane in Playwright plan and added corresponding unit testsThis will update automatically on new commits.
Greptile Summary
The PR adjusts AI-mode marketplace header and table layouts.
Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Important Files Changed
Reviews (8): Last reviewed commit: "Merge branch 'main' into fix-ui-marketpl..." | Re-trigger Greptile