fix(dq): backport #30464 to 2.0 — scope Data Observability locator + restore incident reopen - #30529
fix(dq): backport #30464 to 2.0 — scope Data Observability locator + restore incident reopen#30529ShaileshParmar11 wants to merge 1 commit into
Conversation
…se page (#30464) * fix(dq): restore in-place reopen of resolved incidents on the Test Case page * fix(dq): guard incident-header effect against stale state and late responses * fix(test): scope 'Data Observability' locator to profiler to avoid strict-mode violation * fix(test): wrap Data Observability locator chain to satisfy prettier printWidth (cherry picked from commit 2ce362e) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
Code Review ✅ ApprovedBackports the Data Observability locator scope and incident reopen fix from main to resolve strict-mode test failures in the 2.0 release branch. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|



What
Backports #30464 to the
2.0release branch.Why
2.0Playwright E2E is red on the DataQuality and TestSuiteMultiPipeline shards with a strict-mode violation:The Asset Health widget added a second "Data Observability" text node, so the bare
getByText('Data Observability')— including the one in the sharedvisitCreateTestCasePanelFromEntityPagehelper (utils/dataQuality.ts) that nearly every DataQuality spec routes through — now matches two elements and fails. This was fixed onmainby #30464 but2.0diverged before it landed, so it never got the fix.Evidence: run 30228314274 — shard 3 (DataQuality) 100 hits, shard 5 (TestSuiteMultiPipeline) 14 hits, all the same collision.
What's included
Straight cherry-pick of #30464 (
2ce362e00734), which contains:getByText('Data Observability')togetByTestId('profiler')inutils/dataQuality.tsandTestSuiteMultiPipeline.spec.ts(unblocks the whole DQ suite)useTestCaseIncidentHeader.ts+ tests)Cherry-picked cleanly with no conflicts.
🤖 Generated with Claude Code
Greptile Summary
Restores reliable Data Quality navigation and resolved-incident reopening.
Confidence Score: 5/5
The PR appears safe to merge, with the locator and resolved-incident changes aligned with existing UI and backend contracts.
The scoped locators remove the demonstrated strict-mode collision, while incidentStatus is supported by the Test Case API and the hook safely resolves its associated task without allowing obsolete asynchronous responses to overwrite current state.
Important Files Changed
Sequence Diagram
Reviews (1): Last reviewed commit: "fix(dq): restore in-place reopen of reso..." | Re-trigger Greptile