Fix delete modal messages wrapping issue by anuj-kumary · Pull Request #30725 · open-metadata/OpenMetadata

anuj-kumary · 2026-07-30T19:45:13Z

Describe your changes:

Issue -

Type of change:

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Not applicable.

Checklist:

I have read the CONTRIBUTING document.
My PR title is Fixes <issue-number>: <short explanation>
My PR is linked to a GitHub issue via Fixes #<issue-number> above.
I have commented on my code, particularly in hard-to-understand areas.
For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
For UI changes: I attached a screen recording and/or screenshots above.
I have added tests (unit / integration / Playwright as applicable) and listed them above.

Summary by Gitar

UI Bug Fix:
- Added tw:break-words, tw:min-w-0, and tw:w-full in DeleteModal.tsx to fix text wrapping issues in delete modal messages.

_{This will update automatically on new commits.}

Greptile Summary

Updates the delete modal’s header layout to support long messages.

Allows the header content container to shrink within the modal.
Enables long words in delete messages to wrap instead of overflowing.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
openmetadata-ui/src/main/resources/ui/src/components/common/DeleteModal/DeleteModal.tsx	Adds width, minimum-width, and word-breaking utilities to prevent delete-modal message overflow.

_{Reviews (2): Last reviewed commit: "Merge branch 'main' into delete-modal-sp..." | Re-trigger Greptile}

github-actions · 2026-07-30T19:59:18Z

Jest test Coverage

UI tests summary

Lines	Statements	Branches	Functions
	66.01% (77618/117580)	49.96% (46820/93707)	51.15% (14079/27521)

github-actions · 2026-07-30T20:40:39Z

✅ Playwright Results — workflow succeeded

Validated commit 084b173d277fea6683afe3f3a9a9462a9535ac07 in Playwright run 30733807045, attempt 1.

✅ 548 passed · ❌ 0 failed · 🟡 2 flaky · ⏭️ 3 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 53m 34s

⏱️ Max setup 2m 55s · max shard execution 17m 56s · max shard-job elapsed before upload 21m 19s · reporting 7s

🌐 201.36 requests/attempt · 2.83 app boots/UI scenario · 29.28% common-shard skew

Optimization targets still in progress:

Common shard skew was 29.28% (convergence target: at most 15%).
Browser traffic was 201.36 requests per attempt (convergence target: fewer than 200).
Application boot ratio was 2.83 per UI scenario (1621 boots / 573 scenarios; convergence target: at most 1).

Shard	Passed	Flaky	Skipped
✅ Shard chromium-01	143	0	3
🟡 Shard chromium-02	132	1	0
✅ Shard chromium-03	123	0	0
✅ Shard data-asset-rules-01	61	0	0
✅ Shard domain-isolation-01	14	0	0
✅ Shard global-state-01	34	0	0
✅ Shard ingestion-01	1	0	0
✅ Shard reindex-01	2	0	0
✅ Shard search-01	10	0	0
🟡 Shard search-rbac-01	28	1	0

🟡 2 flaky test(s) (passed on retry)

Pages/Entity.spec.ts › Domain Propagation (shard chromium-02, 1 retry)
Flow/SearchRBAC.spec.ts › User with permission (shard search-rbac-01, 1 retry)

📦 Download artifacts

How to debug locally

# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

github-actions · 2026-07-31T21:15:40Z

🚦 Removed from the merge queue — `failed_checks` (2026-07-31T21:15:29Z)

These checks failed on merge-queue commit 2605d9e:

playwright-summary — failure
playwright-ci-postgresql (chromium-21, chromium-21.json, 3, chromium, false) — failure

github-actions · 2026-08-01T07:43:20Z

🚦 Removed from the merge queue — `failed_checks` (2026-08-01T07:43:12Z)

These checks failed on merge-queue commit b0df5d6:

playwright-summary — failure
plan-playwright — failure

…ock the merge queue (#30784) * ci(playwright): raise the chromium shard budget to 21 minutes The chromium lane outgrew a 19-minute shard. At the COMMON_MAX_SHARDS ceiling of 24 the heaviest shard is predicted at 19.2m, so assign_lane_within_budget() raises SystemExit and full-mode planning aborts before a single test runs. Every merge_group run today failed this way (PRs #30705, #30768, #30458, #30725, #30754), while pull_request_target runs pass because targeted selection is far smaller. Raise COMMON_SHARD_BUDGET_MS from 19m to 21m. At 24 shards the heaviest is 19.2m, so the loop is guaranteed to converge at or before the ceiling. 21m stays inside the 25m `timeout` wrapper around `npx playwright test` and the 35m playwright-ci-postgresql job clock, leaving ~4m of headroom. Note the common lane now sits 1m above the dedicated lanes rather than 1m below. The strict 20-minute TARGET_MS ceiling is unaffected: it bounds a single atomic unit, not a shard, so a 21m shard built from units each under 20m does not trip it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * test(playwright): cover full-mode allocator convergence at the shard ceiling Addresses review on #30784. assign_lane_within_budget() was only exercised in "targeted" mode, so neither the full-mode convergence path nor the SystemExit at COMMON_MAX_SHARDS had coverage -- the exact code path that took the merge queue down. Add both: - test_full_mode_chromium_converges_at_the_shard_ceiling builds a lane that needs the window above 19m and asserts the allocator converges at or before the ceiling. Verified as a real guard: with the budget reverted to 19m it fails with "needs more than 24 shards ... heaviest shard is predicted at 20.4m". - test_full_mode_chromium_reports_a_lane_the_ceiling_cannot_hold pins the SystemExit path, which had no coverage at all. Also reword the budget comment: ~4m of headroom is relative to the 25m playwright timeout wrapper specifically, not to the 35m job clock, which is looser and additionally absorbs setup/teardown. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

github-actions · 2026-08-01T21:01:56Z

🚦 Removed from the merge queue — `failed_checks` (2026-08-01T21:01:48Z)

These checks failed on merge-queue commit fb44a01:

playwright-summary — failure
playwright-ci-postgresql (chromium-12, chromium-12.json, 3, chromium, false) — failure

sonarqubecloud · 2026-08-02T05:34:57Z

Quality Gate passed for 'open-metadata-ui'

Issues
1177 New issues
0 Accepted issues

Measures
13 Security Hotspots
0.0% Coverage on New Code
3.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-08-02T11:01:28Z

Changes have been cherry-picked to the 1.13 branch.

(cherry picked from commit f8296c3)

github-actions · 2026-08-02T11:01:31Z

Changes have been cherry-picked to the 2.0 branch.

(cherry picked from commit f8296c3)

gitar-bot · 2026-08-02T11:04:40Z

Code Review ✅ Approved

Fixes text wrapping issues in delete modal messages with proper spacing adjustments. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

`Compact`
`gitar display:verbose`

_{Was this helpful? React with 👍 / 👎 | Gitar | Powered by Gitar — free for open source}

Fix delete modal messages wrapping issue

2e81e8e

anuj-kumary self-assigned this Jul 30, 2026

anuj-kumary requested a review from a team as a code owner July 30, 2026 19:45

anuj-kumary added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch skip-pr-checks Bypass PR metadata validation check labels Jul 30, 2026

Merge branch 'main' into delete-modal-spacing

0c30c17

anuj-kumary temporarily deployed to test July 30, 2026 20:18 — with GitHub Actions Inactive

anuj-kumary enabled auto-merge July 31, 2026 10:17

Rohit0301 approved these changes Jul 31, 2026

View reviewed changes

anuj-kumary added this pull request to the merge queue Jul 31, 2026

karanh37 reviewed Jul 31, 2026

View reviewed changes

Comment thread openmetadata-ui/src/main/resources/ui/src/components/common/DeleteModal/DeleteModal.tsx

karanh37 requested changes Jul 31, 2026

View reviewed changes

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 31, 2026

Merge branch 'main' into delete-modal-spacing

0949d2d

anuj-kumary enabled auto-merge August 1, 2026 05:44

anuj-kumary added this pull request to the merge queue Aug 1, 2026

ShaileshParmar11 mentioned this pull request Aug 1, 2026

ci(playwright): raise the chromium shard budget to 21 minutes to unblock the merge queue #30784

Merged

1 task

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 1, 2026

anuj-kumary added this pull request to the merge queue Aug 1, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 1, 2026

Merge branch 'main' into delete-modal-spacing

084b173

anuj-kumary enabled auto-merge August 2, 2026 05:15

anuj-kumary temporarily deployed to test August 2, 2026 05:46 — with GitHub Actions Inactive

anuj-kumary added this pull request to the merge queue Aug 2, 2026

Merged via the queue into main with commit f8296c3 Aug 2, 2026
76 of 77 checks passed

anuj-kumary deleted the delete-modal-spacing branch August 2, 2026 10:59

github-actions Bot pushed a commit that referenced this pull request Aug 2, 2026

Fix delete modal messages wrapping issue (#30725)

67c75d5

(cherry picked from commit f8296c3)

github-actions Bot pushed a commit that referenced this pull request Aug 2, 2026

Fix delete modal messages wrapping issue (#30725)

2216c4f

(cherry picked from commit f8296c3)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix delete modal messages wrapping issue - #30725

Fix delete modal messages wrapping issue#30725
anuj-kumary merged 4 commits into
mainfrom
delete-modal-spacing

anuj-kumary commented Jul 30, 2026 •

edited by greptile-apps Bot

Loading

Uh oh!

github-actions Bot commented Jul 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 30, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 1, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 1, 2026

Uh oh!

sonarqubecloud Bot commented Aug 2, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 2, 2026

Uh oh!

github-actions Bot commented Aug 2, 2026

Uh oh!

gitar-bot Bot commented Aug 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

anuj-kumary commented Jul 30, 2026 • edited by greptile-apps Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes:

Type of change:

High-level design:

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Checklist:

Summary by Gitar

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

github-actions Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jest test Coverage

UI tests summary

Uh oh!

github-actions Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Playwright Results — workflow succeeded

Performance

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 31, 2026

🚦 Removed from the merge queue — failed_checks (2026-07-31T21:15:29Z)

Uh oh!

Uh oh!

github-actions Bot commented Aug 1, 2026

🚦 Removed from the merge queue — failed_checks (2026-08-01T07:43:12Z)

Uh oh!

Uh oh!

github-actions Bot commented Aug 1, 2026

🚦 Removed from the merge queue — failed_checks (2026-08-01T21:01:48Z)

Uh oh!

sonarqubecloud Bot commented Aug 2, 2026

Quality Gate passed for 'open-metadata-ui'

Uh oh!

Uh oh!

github-actions Bot commented Aug 2, 2026

Uh oh!

github-actions Bot commented Aug 2, 2026

Uh oh!

gitar-bot Bot commented Aug 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

anuj-kumary commented Jul 30, 2026 •

edited by greptile-apps Bot

Loading

github-actions Bot commented Jul 30, 2026 •

edited

Loading

github-actions Bot commented Jul 30, 2026 •

edited

Loading

🚦 Removed from the merge queue — `failed_checks` (2026-07-31T21:15:29Z)

🚦 Removed from the merge queue — `failed_checks` (2026-08-01T07:43:12Z)

🚦 Removed from the merge queue — `failed_checks` (2026-08-01T21:01:48Z)