fix(playwright): keep ExploreBrowse fixtures inside the capped service aggregate bucket - #30884
Merged
Conversation
…e aggregate bucket
harsh-vador
enabled auto-merge
August 3, 2026 15:59
Code Review ✅ ApprovedPrefixes ExploreBrowse test fixtures with '0-' to ensure service names consistently land within the capped search aggregate bucket on shared environments. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar | Powered by Gitar — free for open source |
anuj-kumary
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Problem
ExploreBrowse.spec.tswas flaky on shared environments. The Explore tree's service drill-down goes throughPOST /api/v1/search/aggregate, which caps the service bucket atsize=166(SIZE.X_LARGE) and sorts it by_keyASC(
ElasticSearchAggregationManager). The test fixtures were created with defaultpw-*service names, which sort mid-list — once more than 166pw-*services accumulate on the environment, the fixture service falls outside the returnedbucket, never renders in the tree, and the drill-down steps fail.
Fix
Prefix the fixture service names with
0-so they sort first and always land inside the capped bucket, regardless of how many otherpw-*services exist. Mirrors the approach in #30881 forExploreTree.spec.ts.