Skip to content

Backport #29070 common pages and settings lazy-loading to 1.13 - #31045

Open
shah-harshit wants to merge 2 commits into
ui/direct-1.13-seq25-29065-domain-glossary-lazyfrom
ui/direct-1.13-seq26-29070-common-pages-settings-lazy
Open

Backport #29070 common pages and settings lazy-loading to 1.13#31045
shah-harshit wants to merge 2 commits into
ui/direct-1.13-seq25-29065-domain-glossary-lazyfrom
ui/direct-1.13-seq26-29070-common-pages-settings-lazy

Conversation

@shah-harshit

Copy link
Copy Markdown
Contributor

Summary

Tracking

Testing

  • git diff --check HEAD~1..HEAD

@shah-harshit
shah-harshit requested a review from a team as a code owner August 5, 2026 13:32
@shah-harshit shah-harshit added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check labels Aug 5, 2026
@shah-harshit shah-harshit self-assigned this Aug 5, 2026
@greptile-apps

greptile-apps Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Too many files changed for review (139 files, 100 file limit).

Bypass the limit by tagging @greptile-apps to review.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

❌ UI Checkstyle Failed

❌ ESLint + Prettier + Organise Imports (src)

One or more source files have linting or formatting issues.

❌ Tailwind Audit

Hardcoded Tailwind values found. Use a design-system utility (run yarn tw-audit:report for the token each value maps to).

❌ Antd + Less Deprecation Guard

A new antd import or new .less file was added. Use UntitledUI + Tailwind for new work.

Affected files

at Function._resolveFilename (node:internal/modules/cjs/loader:1401:15)
at defaultResolveImpl (node:internal/modules/cjs/loader:1057:19)
at resolveForCJSWithHooks (node:internal/modules/cjs/loader:1062:22)
at Function._load (node:internal/modules/cjs/loader:1211:37)
at TracingChannel.traceSync (node:diagnostics_channel:322:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:171:5)
at node:internal/main/run_main_module:36:49 {


Fix locally (fast - only checks files changed in this branch):

make ui-checkstyle-changed

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.83% (61832/96857) 44.69% (33469/74884) 46.94% (10271/21880)

@shah-harshit
shah-harshit force-pushed the ui/direct-1.13-seq25-29065-domain-glossary-lazy branch from 4101bc0 to fae3c0b Compare August 6, 2026 07:33
* feat(ui): update Common Components, Pages & Settings for lazy-load utility pattern (#29070)

* feat(ui): update Common Components, Pages & Settings for lazy-load utility pattern

Updates Common Components, MyData, Customization, DataAssets and remaining pages to import from extracted pure utility modules. Updates EntityUtils, BlockEditorUtils, formUtils, CuratedAssetsUtils imports. Updates Settings, Knowledge Center, Context Center components for consistent utility usage.

Ref: open-metadata/openmetadata-collate#4230

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix build, test and checkstyle

* fix checkstyle

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix 1.13 group 12 unit tests

* Fix task description submit tests

* Fix popup container imports

* Fix block editor pure util imports

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
(cherry picked from commit f5426b7)
@shah-harshit
shah-harshit force-pushed the ui/direct-1.13-seq26-29070-common-pages-settings-lazy branch from 1f1eee2 to 76c2699 Compare August 6, 2026 07:51
@gitar-bot

gitar-bot Bot commented Aug 6, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Backports common pages and settings lazy-loading updates to the 1.13 branch while preserving custom-property date parsing helpers. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar | Powered by Gitar — free for open source

@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2026

Copy link
Copy Markdown

…i/direct-1.13-seq26-29070-common-pages-settings-lazy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant