test(e2e): make expandLineageSection wait on state instead of proxies

[ShaileshParmar11]

Problem

Two tests in InputOutputPorts.spec.ts have been flaky in 16 of the last 16 AUT 2.0 nightly runs:

• Section 7: Fullscreen Mode › Toggle fullscreen mode
• Section 4: Removing Ports › Remove last port shows empty state

Both fail the first attempt on a 60s timeout and pass on retry, so they are permanently in the flaky column and never block a run.

Root cause

expandLineageSection had three defects, all variants of waiting on a proxy rather than the actual state:

1. Unconditional toggle. The accordion header is a toggle, but the helper clicked it on every call — despite its own doc comment saying "Only expands if currently collapsed". Calling it on an already-expanded section collapses it, and because no /portsView request follows a collapse, the subsequent waitForResponse hangs until the test timeout.

2. Ambiguous response matcher. url.includes('/portsView') cannot distinguish the lineage fetch from the port-count probe — both hit the same endpoint. The wait could therefore resolve on the counts response while the lineage request was still in flight. The count probe always carries pagination params, so excluding inputLimit= targets the lineage call specifically.

3. Vacuous loader wait. toHaveCount(0) on [data-testid="loader"] passes when React has not yet mounted the loader, letting callers act on a panel that is still loading. The helper now also waits for a terminal state — ports-lineage-view or .ports-lineage-view-empty.

Regression test

Added Lineage stays expanded when expandLineageSection runs twice. Against the old helper it fails with the same signature as the flaky tests:

Test timeout of 60000ms exceeded.
Error: page.waitForResponse: Target page, context or browser has been closed
   at ../utils/domain.ts:1693

With the fix it passes.

Verification

Check	Result
New regression test, before fix	failed — 60s timeout, same signature
New regression test, after fix	passed
Full InputOutputPorts.spec.ts	44/44 passed
--repeat-each=20 on both flaky tests + new test	60/60 passed

All callers of expandLineageSection live in InputOutputPorts.spec.ts, so the blast radius is one file.

Note on what this proves. Both flaky tests already passed 10/10 locally before this change — the trigger only appears under CI load. Local green therefore demonstrates no regression, not that the CI flake is gone. The idempotency defect (1) is conclusively fixed and covered by a test; confirmation for the flake itself should come from the next few 2.0 nightlies.

Not included

Investigation also surfaced a separate backend issue: /portsView sources data from findToWithOffset + Entity.getEntities(..., NON_DELETED) but total from a separate countFindTo, and silently drops unresolvable records without adjusting total. Soft-deleting an asset that is a port reproduces it deterministically — the UI then shows "Input Ports (1)" beside "assign assets to this Data Product". That is a real user-facing bug but it would not have stabilised these tests, so it belongs in its own change.

🤖 Generated with Claude Code

[github-actions]

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

• No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

[gitar-bot]

Code Review ✅ Approved

Robustness improvements to the expandLineageSection e2e test helper by adding idempotency checks, precise response matching, and terminal state waits to resolve nightly test flakiness. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact

gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar | Powered by Gitar — free for open source}

[github-actions]

❌ UI Checkstyle Failed

❌ Antd + Less Deprecation Guard

A new antd import or new .less file was added. Use UntitledUI + Tailwind for new work.

Affected files

at Function._resolveFilename (node:internal/modules/cjs/loader:1401:15)
at defaultResolveImpl (node:internal/modules/cjs/loader:1057:19)
at resolveForCJSWithHooks (node:internal/modules/cjs/loader:1062:22)
at Function._load (node:internal/modules/cjs/loader:1211:37)
at TracingChannel.traceSync (node:diagnostics_channel:322:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:171:5)
at node:internal/main/run_main_module:36:49 {

---

Fix locally (fast - only checks files changed in this branch):

make ui-checkstyle-changed