fix(test): increase retry for AUT and enable traces - #31248
Conversation
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
Code Review ✅ Approved 1 resolved / 1 findingsIncreases test retry counts and enables Playwright traces on failure to improve test reliability. Consider increasing the wait margin slightly past the 120s token expiry to prevent flaky refresh timing. ✅ 1 resolved✅ Edge Case: Wait leaves only ~2s margin past 120s token expiry
OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
✅ Playwright Results — workflow succeededValidated commit ✅ 46 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky PerformanceBlocking targets: ✅ met · Optimization targets: 🟡 in progress Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting. 🕒 Full workflow signal wall (to summary) 40m 2s ⏱️ Max setup 1m 34s · max shard execution 5m 8s · max shard-job elapsed before upload 9m 16s · reporting 3s 🌐 131.87 requests/attempt · 1.29 app boots/UI scenario · 0.00% common-shard skew Optimization targets still in progress:
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
|
Changes have been cherry-picked to the 2.0 branch. |
(cherry picked from commit b8e00ad)
|
Failed to cherry-pick changes to the 1.13 branch. |
Describe your changes:
Fixes #
I worked on ... because ...
Type of change:
High-level design:
N/A — small change.
Tests:
Use cases covered
Unit tests
Backend integration tests
Ingestion integration tests
Playwright (UI) tests
Manual testing performed
UI screen recording / screenshots:
Not applicable.
Checklist:
Fixes <issue-number>: <short explanation>Fixes #<issue-number>above.Summary by Gitar
Login.spec.ts.PLAYWRIGHT_IS_OSS.This will update automatically on new commits.