Skip to content

Backport #31205 preserve tag recognizer config on ingestion PUT to 2.0 - #31305

Merged
IceS2 merged 1 commit into
2.0from
backport/31205-2.0
Aug 10, 2026
Merged

Backport #31205 preserve tag recognizer config on ingestion PUT to 2.0#31305
IceS2 merged 1 commit into
2.0from
backport/31205-2.0

Conversation

@IceS2

@IceS2 IceS2 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Describe your changes:

Backport of #31205.

Metadata ingestion upserts source tags with a bare CreateTag carrying only classification, name and description. CreateTag defaults recognizers to an empty list and autoClassificationEnabled to false, so TagUpdater could not tell a caller that never heard of those fields from one deliberately clearing them — every ingestion run stripped the tag's recognizers and switched auto-classification off.

This branch is affected: TagUpdater.entitySpecificUpdate records all three fields unconditionally, preserveRecognizerConfigOnPut is absent, piiTagsWithRecognizers.json seeds PII.Sensitive with 39 recognizers, and tag_utils sends the bare CreateTagRequest.

The classification-level twin of this bug (autoClassificationConfig, #29668) is already present on this branch, so without this backport the branch is half-fixed: a bare ingestion PUT can no longer wipe a classification's config, but it still wipes a tag's recognizers. Both surface to users as auto-classification silently stopping.

Cherry-picked clean with no conflicts. TagResourceIT#test_putPreservesRecognizers_ingestionScenario passes on this branch.

Type of change:

  • Bug fix

Metadata ingestion upserts source tags with a bare CreateTag carrying only
classification, name and description. CreateTag defaults recognizers to an
empty list and autoClassificationEnabled to false, so the updater could not
tell a caller that never heard of these fields from one deliberately clearing
them, and every ingestion run stripped the tag's recognizers and switched
auto-classification off. PII.Sensitive ships 39 recognizers and is reachable
this way through the system-tag name match in tag_utils.

Treat the recognizer configuration as one unit that a PUT only touches when
it names recognizers. Clearing via PATCH is unaffected, which is the path the
UI uses. This mirrors the classification-level guard added in #29668.

(cherry picked from commit fd94194)
@IceS2
IceS2 requested a review from a team as a code owner August 10, 2026 15:48
@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions github-actions Bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Aug 10, 2026
@gitar-bot

gitar-bot Bot commented Aug 10, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Backports tag recognizer config preservation during ingestion PUT requests to fix tag recognizers and auto-classification settings being incorrectly wiped. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@IceS2
IceS2 merged commit 3ea4a19 into 2.0 Aug 10, 2026
80 of 83 checks passed
@IceS2
IceS2 deleted the backport/31205-2.0 branch August 10, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ingestion safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants