Skip to content

Fix #4780 & #4739 - ConnectionArguments with inner dict#4798

Merged
vivekratnavel merged 2 commits into
open-metadata:mainfrom
pmbrull:issue-4780
May 9, 2022
Merged

Fix #4780 & #4739 - ConnectionArguments with inner dict#4798
vivekratnavel merged 2 commits into
open-metadata:mainfrom
pmbrull:issue-4780

Conversation

@pmbrull

@pmbrull pmbrull commented May 9, 2022

Copy link
Copy Markdown
Member

Describe your changes :

This PR fixes #4780 and fixes #4739

image

Resolution:

  • ConnectionOptions are used to add parameters to the connection URL -> values should be string
  • ConnectionArguments are being passed to connect_args in SQLAlchemy -> In there we are passing the data as-is.

Type of change :

  • Bug fix
  • Improvement
  • New feature
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation

Frontend Preview (Screenshots) :

For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

  • I have read the CONTRIBUTING document.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@pmbrull
pmbrull requested review from a team, harshach and vivekratnavel May 9, 2022 09:48
@github-actions

github-actions Bot commented May 9, 2022

Copy link
Copy Markdown
Contributor

Schema Change Detected. Needs ingestion-core version bump

Please run make core_bump_version_dev in the project's root and commit the changes to _version.py in this PR. Please ignore if this has been handled already.

@sonarqubecloud

sonarqubecloud Bot commented May 9, 2022

Copy link
Copy Markdown

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud

sonarqubecloud Bot commented May 9, 2022

Copy link
Copy Markdown

[catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vivekratnavel
vivekratnavel merged commit 6fdd1c4 into open-metadata:main May 9, 2022
@pmbrull
pmbrull deleted the issue-4780 branch May 9, 2022 19:42
@TeddyCr TeddyCr mentioned this pull request Jul 16, 2026
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test Connection API should support dict for connection options Connection Arguments with inner dicts

3 participants