Skip to content

Fix #5442 UI Reactions disappear when opening side drawer - #5449

Merged
vivekratnavel merged 2 commits into
mainfrom
reactions-fix
Jun 14, 2022
Merged

Fix #5442 UI Reactions disappear when opening side drawer#5449
vivekratnavel merged 2 commits into
mainfrom
reactions-fix

Conversation

@Sachin-chaurasiya

Copy link
Copy Markdown
Contributor

Describe your changes :

I worked on fixing Reactions issues

  • Reactions are getting disappear when the side drawer is opened
  • Reactions are not getting updated in real-time

Type of change :

  • Bug fix

Frontend Preview (Screenshots) :

Checklist:

  • I have read the CONTRIBUTING document.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@open-metadata/ui

@Sachin-chaurasiya Sachin-chaurasiya self-assigned this Jun 14, 2022
@Sachin-chaurasiya
Sachin-chaurasiya temporarily deployed to cypress June 14, 2022 10:54 Inactive
@Sachin-chaurasiya
Sachin-chaurasiya temporarily deployed to cypress June 14, 2022 10:54 Inactive
@Sachin-chaurasiya Sachin-chaurasiya added the UI UI specific issues label Jun 14, 2022
@Sachin-chaurasiya
Sachin-chaurasiya requested a review from a team June 14, 2022 10:54
@Sachin-chaurasiya
Sachin-chaurasiya temporarily deployed to cypress June 14, 2022 10:54 Inactive
@Sachin-chaurasiya
Sachin-chaurasiya temporarily deployed to cypress June 14, 2022 10:54 Inactive
@Sachin-chaurasiya Sachin-chaurasiya linked an issue Jun 14, 2022 that may be closed by this pull request
@Sachin-chaurasiya
Sachin-chaurasiya temporarily deployed to cypress June 14, 2022 15:07 Inactive
@Sachin-chaurasiya
Sachin-chaurasiya temporarily deployed to cypress June 14, 2022 15:07 Inactive
@sonarqubecloud

Copy link
Copy Markdown

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

40.0% 40.0% Coverage
21.5% 21.5% Duplication

@cypress

cypress Bot commented Jun 14, 2022

Copy link
Copy Markdown



Test summary

45 0 3 0


Run details

Project openmetadata
Status Passed
Commit eae0001
Started Jun 14, 2022 10:07 PM
Ended Jun 14, 2022 10:20 PM
Duration 13:19 💡
OS Linux Ubuntu - 20.04
Browser Chrome 102

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@sonarqubecloud

Copy link
Copy Markdown

[catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Sachin-chaurasiya
Sachin-chaurasiya temporarily deployed to cypress June 14, 2022 21:53 Inactive
@Sachin-chaurasiya
Sachin-chaurasiya temporarily deployed to cypress June 14, 2022 21:53 Inactive
@vivekratnavel
vivekratnavel merged commit 8dfda81 into main Jun 14, 2022
@vivekratnavel
vivekratnavel deleted the reactions-fix branch June 14, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI Reactions disappear when opening side drawer

2 participants