This repository was archived by the owner on Sep 30, 2022. It is now read-only.
Topic/opal pretty output #1068
Closed
Topic/opal pretty output #1068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When invoking, for example, `ompi_info` with: -a --params foo all --params foo bar it's useful to have the appropriate components and their versions be displayed, regardless of whether they have registered any parameters. Signed-off-by: Karol Mroz <mroz.karol@gmail.com> (cherry picked from commit open-mpi/ompi@20e448c)
Pass component_map to opal_info_do_params(). It will be needed to output component versions. Signed-off-by: Karol Mroz <mroz.karol@gmail.com> (cherry picked from commit open-mpi/ompi@a468c3b)
Signed-off-by: Karol Mroz <mroz.karol@gmail.com> (cherry picked from commit open-mpi/ompi@296bd15)
When listing available parameters, add the component name to the MCA framework field. Parsable option is already doing this, makes sense for the pretty print option to do it as well. Signed-off-by: Karol Mroz <mroz.karol@gmail.com> (cherry picked from commit open-mpi/ompi@a3229c3)
Use a dashed line to separate parameters based on component when pretty printing. Signed-off-by: Karol Mroz <mroz.karol@gmail.com> (cherry picked from commit open-mpi/ompi@e1eb23e)
|
The consensus was to merge this in to 2.0.0. If it can't make it in to 2.0.0 then it needs to wait till the 3.x release stream. |
|
Test PASSed. |
|
@hppritcha Is this materially different than #1057? |
|
no I had forgotten there was already a PR for this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge of open-mpi/ompi#1515 open-mpi/ompi#1516 and open-mpi/ompi#1518 in to v2.x
@kmroz please double check