-
Notifications
You must be signed in to change notification settings - Fork 931
opal_info_support: output component versions #1515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
FWIW: I like having the dashed lines separating the output - made it a lot easier to read, for me. |
|
@rhc54 😄 For me too! Once we nail down a good approach to this bug, I'll be happy to try something similar in another pull request. |
|
Mellanox tests (I've no idea what they do 😄) failed: Doesn't seem related to the ompi_info changes? |
|
Completely unrelated - ignore them |
|
That's what I thought. I did restart the testsuite though... |
|
👍 Looks good to me... |
|
Curious how this affects --parsable? Does this cause any duplicate lines there? Not sure we care but it would be good to know. |
|
@hjelmn Good call. There don't appear to be any duplicate lines. |
Pass component_map to opal_info_do_params(). It will be needed to output component versions. Signed-off-by: Karol Mroz <mroz.karol@gmail.com>
|
Tabs... fixing now... done. |
When invoking, for example, `ompi_info` with: -a --params foo all --params foo bar it's useful to have the appropriate components and their versions be displayed, regardless of whether they have registered any parameters. Signed-off-by: Karol Mroz <mroz.karol@gmail.com>
Hopefully a better approach than #1514. Aims at fixing #1396.
Tests:
@jsquyres / @hjelmn - What are your thoughts, gents?