Skip to content
This repository was archived by the owner on Sep 30, 2022. It is now read-only.

Conversation

@kawashima-fj
Copy link
Member

PR for v1.10.3

@jsquyres please review

bot:label:bug
bot:milestone:v1.10.3

Not critical; can be delayed to v1.10.4

(cherry picked from part of commit open-mpi/ompi@4566286)

Though the `MPI_DUP_FN` subroutine is depricated, it is not yet removed
as of MPI-3.1.

(cherry picked from commit open-mpi/ompi@10c11ff)
Same order for `comm`, `type`, and `win`.

No code change.

(cherry picked from commit open-mpi/ompi@334c63c)
And insert necessary empty lines and remove unnecessary empty lines.

No code change.

(cherry picked from commit open-mpi/ompi@96e93a9)
@ompiteam-bot ompiteam-bot added this to the v1.10.3 milestone Apr 15, 2016
@jsquyres
Copy link
Member

@kawashima-fj Compared to #1083, this PR seems incomplete...?

This commit adds the following symbols

  MPI_Alloc_mem_cptr_f
  MPI_Alloc_mem_cptr_f08
  PMPI_Alloc_mem_cptr_f
  PMPI_Alloc_mem_cptr_f08

These are implemented in the same way as other `_cptr` routines.

(backported from commit open-mpi/ompi@17d32ac)
@kawashima-fj
Copy link
Member Author

@jsquyres Sorry, I added 2 commits which had conflicts. Please review again.
This should be a complete PR. Though #1083 consists of 10 commits, this PR consist of 9 commits because open-mpi/ompi@17d32ac and open-mpi/ompi@e854404 are merged into one commit.

@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1522/ for details.

@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1523/ for details.

@jsquyres
Copy link
Member

@kawashima-fj Ah, I just noticed that you added the new commits. Sorry -- I missed the mail (I get too much per day... 😦 ), and the "pushed-back" label was still on this PR). Pro tip: once you address review comments brought up in a PR, you can remove the "pushed-back" label to let the reviewer know that it's ready to review again, like this:

bot:nolabel:pushed-back

@jsquyres
Copy link
Member

👍

@rhc54 rhc54 merged commit 34e5a86 into open-mpi:v1.10 Apr 19, 2016
@kawashima-fj kawashima-fj deleted the pr/v1.10/fortran-binding-fix branch August 12, 2016 00:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants