This repository was archived by the owner on Sep 30, 2022. It is now read-only.
fortran: link the opal-pal.la library directly #516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The libmpi_*.la fortran libraries make some direct calls to libopen-pal.la. In many (most?) cases, having libmpi_* link against libmpi is sufficient (because libmpi pulls in libopen-pal). But when building RPMs on SLES, some compiler/linker flags are used that seem to make this implicit linking not sufficient -- we get missing opal symbols when creating libmpi_mpifh.la. So link in open-pal directly (vs. indirectly), which solves the problem. (cherry picked from commit open-mpi/ompi@a7f897a)
Accidentally added a 2nd _LIBADD in a prior commit. This commit merges them back into a single _LIBADD. (cherry picked from commit open-mpi/ompi@e57861b)
|
@ggouaillardet can you comment/review? These are the two comments from master. |
|
@jsquyres how can i reproduce the initial issue ? |
|
You'll have to ask @miked-mellanox -- I was never able to replicate the issue. See open-mpi/ompi#610 (that PR started as an email from Mike to me; I turned it into a PR, which is why it looks like the conversation started in the middle). |
|
@jsquyres is this ready to merge? |
|
@hppritcha Waiting for @ggouaillardet's review |
|
:+1 I will try to investigate on sles11sp4 later |
|
:bot🏷️reviewed |
jsquyres
added a commit
that referenced
this pull request
Aug 20, 2015
fortran: link the opal-pal.la library directly
alex-mikheev
pushed a commit
to alex-mikheev/ompi-release
that referenced
this pull request
Nov 11, 2015
RFC: Repository update
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
libmpi_*.lafortran libraries make some direct calls tolibopen-pal.la. In many (most?) cases, havinglibmpi_*link againstlibmpiis sufficient (becauselibmpipulls inlibopen-pal). But when building RPMs on SLES, some compiler/linker flags are used that seem to make this implicit linking not sufficient -- we get missing opal symbols when creatinglibmpi_mpifh.la. So link inopen-paldirectly (vs. indirectly), which solves the problem.(cherry picked from commit open-mpi/ompi@a7f897a)
@miked-mellanox Please review -- this is a PR for open-mpi/ompi#711