fortran: link the opal-pal.la library directly #711
Conversation
jsquyres
force-pushed
the
pr/possible-sles-rpm-linker-fix
branch
from
0e913b6 to
ed50b2f
Compare
|
Thanks Jeff! Now it passes and creates .rpm file, buy following spotted during "make install" phase" /usr/bin/make install-exec-hook
make[3]: Entering directory `/tmp/workspace/rpmbuild/BUILD/openmpi-3.0.0a1'
WARNING! Common symbols found:
btl_openib_lex.o: 0000000000000004 C btl_openib_ini_yyleng
btl_openib_lex.o: 0000000000000008 C btl_openib_ini_yytext
show_help_lex.o: 0000000000000004 C opal_show_help_yyleng
show_help_lex.o: 0000000000000008 C opal_show_help_yytext
keyval_lex.o: 0000000000000004 C opal_util_keyval_yyleng
keyval_lex.o: 0000000000000008 C opal_util_keyval_yytext
rmaps_rank_file_lex.o: 0000000000000004 C orte_rmaps_rank_file_leng
rmaps_rank_file_lex.o: 0000000000000008 C orte_rmaps_rank_file_text
hostfile_lex.o: 0000000000000004 C orte_util_hostfile_leng
hostfile_lex.o: 0000000000000008 C orte_util_hostfile_text
make[3]: [install-exec-hook] Error 1 (ignored) |
|
That's part of the build process these days. Have your people help eliminate common symbols. :) Sent from my phone. No type good. On Jul 11, 2015, at 1:20 AM, Mike Dubman <notifications@github.commailto:notifications@github.com> wrote: Thanks Jeff! Now it passes and creates .rpm file, buy following spotted during "make install" phase" /usr/bin/make install-exec-hook — |
The libmpi_*.la fortran libraries make some direct calls to libopen-pal.la. In many (most?) cases, having libmpi_* link against libmpi is sufficient (because libmpi pulls in libopen-pal). But when building RPMs on SLES, some compiler/linker flags are used that seem to make this implicit linking not sufficient -- we get missing opal symbols when creating libmpi_mpifh.la. So link in open-pal directly (vs. indirectly), which solves the problem.
jsquyres
force-pushed
the
pr/possible-sles-rpm-linker-fix
branch
from
ed50b2f to
a7f897a
Compare
fortran: link the opal-pal.la library directly
|
Test FAILed. |
…n_create_dynamic Topic/v1.10/mpi win create dynamic
4 participants
The
libmpi_*.lafortran libraries make some direct calls tolibopen-pal.la. In many (most?) cases, havinglibmpi_*link againstlibmpiis sufficient (becauselibmpipulls inlibopen-pal). But when building RPMs on SLES, some compiler/linker flags are used that seem to make this implicit linking not sufficient -- we get missing opal symbols when creatinglibmpi_mpifh.la. So link inopen-paldirectly (vs. indirectly), which solves the problem.Github won't let me re-open #610, so I'm opening a new PR to continue the work here.