This repository was archived by the owner on Sep 30, 2022. It is now read-only.
V2.x window updates #517
Merged
V2.x window updates #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
master commit open-mpi/ompi@b933eda Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
Member
Author
|
:bot:assign: @jsquyres closes open-mpi/ompi#814 |
…unit info keys master commit open-mpi/ompi@b8356da :bot:assign: @jsquyres closes open-mpi/ompi#814 Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
hjelmn
force-pushed
the
v2.x_window_updates
branch
from
1af2604 to
58527c9
Compare
Member
There was a problem hiding this comment.
Symbols with "_" prefixes are supposed to be the domain of the compiler, not user functions.
Member
Author
There was a problem hiding this comment.
Only in the _[A-Z] case. _[a-z] is meant to designate file scope.
Member
Author
There was a problem hiding this comment.
See C99 § 7.1.3 bullets 1-2. The first designates _[A-Z]* and __* as reserved. The second explicitly allows _[a-z]* for file-scoped identifiers.
Member
|
👍 |
Member
|
@hppritcha I think this is good to go |
alex-mikheev
pushed a commit
to alex-mikheev/ompi-release
that referenced
this pull request
Nov 11, 2015
This commit is related to an RFC from June 2014. Disscussion can be found at: http://www.open-mpi.org/community/lists/devel/2014/07/15140.php The finalize function is set using either the linker option -fini or __attribute__((destructor)) depending on compiler support. I have confirmed that this hybrid approach works with all the major compilers. The attribute is supported by gcc, clang, llvm, xlc, and icc. The fini function will support pgi. If a compiler/linker combination does not support either the destructor or fini function a message will be printed on re-init indicating it is not supported (an improvement over the current behavior-- SEGV). I moved the following to the destructor function: - Class system finalize. This solves a bug when MPI_T_finalize is called before MPI_Init. The only downside to this change is we will leave the footprint of the opal class system after MPI_Finalize. This footprint should be relatively small. This is an alternative to open-mpi#517 but the two PRs are not mutually-exclusive (with some modifications). This commit should also be safe for 1.8.x as it does not change internal or external ABI (open-mpi#517 changes internal ABI). Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
alinask
pushed a commit
to alinask/ompi-release
that referenced
this pull request
Dec 10, 2015
opal/class: enable use of opal classes after opal_class_finalize
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.