Skip to content
This repository was archived by the owner on Sep 30, 2022. It is now read-only.

Conversation

@hppritcha
Copy link
Member

Since there's no support for launching a job under
a debugger using mpirun in the 2.0 release,
if the user tries to use -debug option with mpirun,
print out a help message and abort job launch.

I want this or an equivalent in by COB 1/21/16 for 2.0.0

@jsquyres
@rhc54

Signed-off-by: Howard Pritchard howardp@lanl.gov

@hppritcha hppritcha added this to the v2.0.0 milestone Jan 21, 2016
@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1238/ for details.

@hppritcha
Copy link
Member Author

the travis is failing owing to os-x build failure introduced with PR #896

@hppritcha hppritcha force-pushed the topic/disable_debugger_launch branch from 36f5ce8 to 810d381 Compare January 22, 2016 03:48
@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1246/ for details.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This statement is not quite true -- it works fine with DDT. I think you're trying to say that the "--debug" option is not supported in this release, right? Perhaps:

This version of Open MPI is known to have a problem using the "--debug" option to mpirun, and has therefore disabled it. This functionality will be restored in a future version of Open MPI.

Please see open-mpi/ompi#1225 for further details.

(note that Github abbreviated the full URL for open-mpi/ompi#1225 in the rendering of this comment -- I'd put the full https URL in the help message).

Since there's no support for launching a job under
a debugger using mpirun in the 2.0 release,
if the user tries to use -debug option with mpirun,
print out a help message and abort job launch.

Signed-off-by: Howard Pritchard <howardp@lanl.gov>
@hppritcha hppritcha force-pushed the topic/disable_debugger_launch branch from 810d381 to 030de75 Compare January 22, 2016 21:08
@hppritcha
Copy link
Member Author

@jsquyres check now

@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1249/ for details.

jsquyres added a commit that referenced this pull request Jan 22, 2016
@jsquyres jsquyres merged commit d6efd55 into open-mpi:v2.x Jan 22, 2016
@gpaulsen
Copy link
Member

gpaulsen commented Mar 3, 2016

Ralph mentioned this was broken last week in Issue 1225 Is that a blocker for 2.0?

@hppritcha
Copy link
Member Author

I think you mean the total view support still doesn't work? This pr was to emit a useful message if user tried the --debugger cmd line option. This pr should be reverted once we get the debugger launch capability back. This will not happen for 2.0.0 since we are not moving to pmix 1.2 in this release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants