-
Notifications
You must be signed in to change notification settings - Fork 68
v2.0.0 examples: fix check for Fortran "use mpi" bindings #993
v2.0.0 examples: fix check for Fortran "use mpi" bindings #993
Conversation
The output from "ompi_info --parsable" for the Fortran "use mpi" bindings apparently has changed over time. It is now: "yes (full: ignore TKR)" or "yes (limited: overloading)" (including the quotes) So update the test in examples/Makefile to also look for the quote. (cherry picked from commit open-mpi/ompi@20fade1)
|
@jsquyres that is correct for master and v2.x with grep or with egrep (i have no clue why i need to backquote the interrogation mark with grep and not egrep) so one option is to merge this PR and close #994, |
|
Test PASSed. |
e30aab0 to
6c9e0b5
Compare
Use "-q" option to grep/egrep to suppress output (we only need the exit status). Also, use egrep for the "use mpi" check, because some versions of ompi_info say 'bindings:use_mpi:yes' and others say 'bindings:use_mpi:"yes' (i.e., with the double quote). This regexp will work with both versions. (cherry picked from commit open-mpi/ompi@677a31b)
|
@ggouaillardet This PR now includes open-mpi/ompi@677a31b |
|
Test FAILed. |
|
bot:retest |
|
Test PASSed. |
|
Test PASSed. |
|
👍 |
|
@hppritcha Good to go. |
…makefile v2.0.0 examples: fix check for Fortran "use mpi" bindings
The output from "ompi_info --parsable" for the Fortran "use mpi"
bindings apparently has changed over time. It is now:
(including the quotes)
So update the test in examples/Makefile to also look for the quote.
(cherry picked from commit open-mpi/ompi@20fade1)
@ggouaillardet please review