Skip to content
This repository was archived by the owner on Sep 30, 2022. It is now read-only.

Conversation

@jsquyres
Copy link
Member

The output from "ompi_info --parsable" for the Fortran "use mpi"
bindings apparently has changed over time. It is now:

   "yes (full: ignore TKR)"
or "yes (limited: overloading)"

(including the quotes)

So update the test in examples/Makefile to also look for the quote.

(cherry picked from commit open-mpi/ompi@20fade1)

@ggouaillardet please review

The output from "ompi_info --parsable" for the Fortran "use mpi"
bindings apparently has changed over time.  It is now:

   "yes (full: ignore TKR)"
or "yes (limited: overloading)"

(including the quotes)

So update the test in examples/Makefile to also look for the quote.

(cherry picked from commit open-mpi/ompi@20fade1)
@jsquyres jsquyres added the bug label Feb 29, 2016
@jsquyres jsquyres added this to the v2.0.0 milestone Feb 29, 2016
@jsquyres jsquyres changed the title examples: fix check for Fortran "use mpi" bindings v2.0.0 examples: fix check for Fortran "use mpi" bindings Feb 29, 2016
@ggouaillardet
Copy link
Contributor

@jsquyres that is correct for master and v2.x
v1.10 does not double quote the values.
fwiw, i did a similar thing in mtt, and i used a regex to support all ompi versions

with grep

ompi_info --all --parseable | grep 'bindings:use_mpi:"\?yes'

or with egrep

ompi_info --all --parseable | egrep 'bindings:use_mpi:"?yes'

(i have no clue why i need to backquote the interrogation mark with grep and not egrep)

so one option is to merge this PR and close #994,
and an other option is to update both with (e)regexp

@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1379/ for details.

Use "-q" option to grep/egrep to suppress output (we only need the
exit status).  Also, use egrep for the "use mpi" check, because some
versions of ompi_info say 'bindings:use_mpi:yes' and others say
'bindings:use_mpi:"yes' (i.e., with the double quote).  This regexp
will work with both versions.

(cherry picked from commit open-mpi/ompi@677a31b)
@jsquyres
Copy link
Member Author

jsquyres commented Mar 1, 2016

@ggouaillardet This PR now includes open-mpi/ompi@677a31b

@mellanox-github
Copy link

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1388/ for details.

@jsquyres
Copy link
Member Author

jsquyres commented Mar 1, 2016

bot:retest

@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1385/ for details.

@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1389/ for details.

@ggouaillardet
Copy link
Contributor

👍

@jsquyres
Copy link
Member Author

jsquyres commented Mar 1, 2016

@hppritcha Good to go.

hppritcha added a commit that referenced this pull request Mar 1, 2016
…makefile

v2.0.0 examples: fix check for Fortran "use mpi" bindings
@hppritcha hppritcha merged commit 4662bc4 into open-mpi:v2.x Mar 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants