Skip to content
This repository was archived by the owner on Sep 30, 2022. It is now read-only.

Conversation

@jsquyres
Copy link
Member

The output from "ompi_info --parsable" for the Fortran "use mpi"
bindings apparently has changed over time. It is now:

   "yes (full: ignore TKR)"
or "yes (limited: overloading)"

(including the quotes)

So update the test in examples/Makefile to also look for the quote.

(cherry picked from commit open-mpi/ompi@20fade1)

@ggouaillardet please review

The output from "ompi_info --parsable" for the Fortran "use mpi"
bindings apparently has changed over time.  It is now:

   "yes (full: ignore TKR)"
or "yes (limited: overloading)"

(including the quotes)

So update the test in examples/Makefile to also look for the quote.

(cherry picked from commit open-mpi/ompi@20fade1)
@ggouaillardet
Copy link
Contributor

:bot:assign: @ggouaillardet
:bot🏷️pushed-back

see my comment in #993
this does not work for v1.10, or you can use a regex that works for all versions

@jsquyres
Copy link
Member Author

FWIW, v1.10 does quote the string: https://github.com/open-mpi/ompi-release/blob/v1.10/ompi/tools/ompi_info/param.c#L162-L166

But a regexp that works in all versions is better -- I agree. I'll update master and the two PRs.

@ggouaillardet
Copy link
Contributor

here is what i get

$ ~/local/ompi-v1.10/bin/ompi_info --all --parseable | grep 'bindings:use_mpi:'
bindings:use_mpi:yes (limited: overloading)
bindings:use_mpi:size:deprecated-ompi-info-value

v1.10 does

 fortran_usempi = "yes (full: ignore TKR)";

and, since mca values are not automatically double quoted in v1.10, a quoted string would have been

 fortran_usempi = "\"yes (full: ignore TKR)\"";

@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1380/ for details.

@jsquyres
Copy link
Member Author

@ggouaillardet Ahh... I see: I was looking in the wrong place. opal_info_out() is where the quoting is emitted (not in opal_info/param.c). Looks like that quoting was added in master/v2.x, and not back-ported to v1.10.x. Got it.

Use "-q" option to grep/egrep to suppress output (we only need the
exit status).  Also, use egrep for the "use mpi" check, because some
versions of ompi_info say 'bindings:use_mpi:yes' and others say
'bindings:use_mpi:"yes' (i.e., with the double quote).  This regexp
will work with both versions.

(cherry picked from commit open-mpi/ompi@677a31b)
@jsquyres
Copy link
Member Author

jsquyres commented Mar 1, 2016

@ggouaillardet This PR now includes open-mpi/ompi@677a31b

@mellanox-github
Copy link

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1387/ for details.

@ggouaillardet
Copy link
Contributor

:bot:retest

@ggouaillardet
Copy link
Contributor

👍

@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1390/ for details.

rhc54 pushed a commit that referenced this pull request Mar 8, 2016
…akefile

v1.10 examples: fix check for Fortran "use mpi" bindings
@rhc54 rhc54 merged commit 5bee5d5 into open-mpi:v1.10 Mar 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants