-
Notifications
You must be signed in to change notification settings - Fork 68
v1.10 examples: fix check for Fortran "use mpi" bindings #994
v1.10 examples: fix check for Fortran "use mpi" bindings #994
Conversation
The output from "ompi_info --parsable" for the Fortran "use mpi" bindings apparently has changed over time. It is now: "yes (full: ignore TKR)" or "yes (limited: overloading)" (including the quotes) So update the test in examples/Makefile to also look for the quote. (cherry picked from commit open-mpi/ompi@20fade1)
|
:bot:assign: @ggouaillardet see my comment in #993 |
|
FWIW, v1.10 does quote the string: https://github.com/open-mpi/ompi-release/blob/v1.10/ompi/tools/ompi_info/param.c#L162-L166 But a regexp that works in all versions is better -- I agree. I'll update master and the two PRs. |
|
here is what i get v1.10 does fortran_usempi = "yes (full: ignore TKR)";and, since mca values are not automatically double quoted in v1.10, a quoted string would have been fortran_usempi = "\"yes (full: ignore TKR)\""; |
|
Test PASSed. |
|
@ggouaillardet Ahh... I see: I was looking in the wrong place. |
Use "-q" option to grep/egrep to suppress output (we only need the exit status). Also, use egrep for the "use mpi" check, because some versions of ompi_info say 'bindings:use_mpi:yes' and others say 'bindings:use_mpi:"yes' (i.e., with the double quote). This regexp will work with both versions. (cherry picked from commit open-mpi/ompi@677a31b)
|
@ggouaillardet This PR now includes open-mpi/ompi@677a31b |
|
Test FAILed. |
|
:bot:retest |
|
👍 |
|
Test PASSed. |
…akefile v1.10 examples: fix check for Fortran "use mpi" bindings
The output from "ompi_info --parsable" for the Fortran "use mpi"
bindings apparently has changed over time. It is now:
(including the quotes)
So update the test in examples/Makefile to also look for the quote.
(cherry picked from commit open-mpi/ompi@20fade1)
@ggouaillardet please review