Skip to content

Conversation

@igor-ivanov
Copy link
Member

This PR adapt oshmem API to specification v1.3 (http://www.openshmem.org/site/sites/default/site_files/OpenSHMEM-1.3.pdf)

@jladd-mlnx @hppritcha please review and accept

@hppritcha
Copy link
Member

Should the SHMEM_MINOR_VERSION be set to 3 now? I think @yosefe pointed this out for the PR open-mpi/ompi-release#1073

@igor-ivanov
Copy link
Member Author

yes, I will update minor version

@hppritcha
Copy link
Member

remember to update the minor version number in ompi-release for v2.1

Annex G:
Version 1.3
Added volatile to remotely accessible pointer argument in SHMEM_WAIT
See Sections 8.7.1
Annex G:
Version 1.3
Added volatile to remotely accessible pointer argument in
SHMEM_LOCK
See Sections 8.9.1
…ly pointer argument)

Annex G:
Version 1.3
Added const to every read-only pointer argument
openshmem.org specification does not mention about extension api
but there is an agreemnet to do these changes for related ex api too.
see
Annex G:
Version 1.3
Added const to every read-only pointer argument
@jladd-mlnx
Copy link
Member

Per the conversation I had with @hppritcha this morning, will merge into master to let MTT have a look once these smoke tests complete.

@igor-ivanov
Copy link
Member Author

@jladd-mlnx @hppritcha @yosefe notice from @yosefe was formed as separate commit 75050b4.
Minor version was not updated because other changes should be done later.

@jladd-mlnx
Copy link
Member

Roger that, @igor-ivanov. Thanks for all your efforts here.

@jladd-mlnx jladd-mlnx merged commit 1c62188 into open-mpi:master Apr 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants