Skip to content

OSHMEM: Removing erroneous initialization check #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2016
Merged

OSHMEM: Removing erroneous initialization check #1817

merged 1 commit into from
Jun 27, 2016

Conversation

@shamisp
Copy link
Contributor

@shamisp shamisp commented Jun 24, 2016

Since the introduction of the on-demand proc allocation
the check become erroneous and irrelevant.
Moreover, it completely breaks OpenSHMEM support in OMPI.

Signed-off-by: Pavel Shamis (Pasha) pasharesearch@gmail.com

@shamisp
OSHMEM: Removing erroneous initialization check
1bb7788 
Since the introduction of the on-demand proc allocation
the check become erroneous and irrelevant.
Moreover, it completely breaks OpenSHMEM support in OMPI.

Signed-off-by: Pavel Shamis (Pasha) <pasharesearch@gmail.com>
@shamisp
Copy link
Contributor Author

shamisp commented Jun 24, 2016

@yosefe @hjelmn please take a look.

@jsquyres
Copy link
Member

jsquyres commented Jun 24, 2016

@shamisp Are you saying this is a blocker for v2.0.0? If so, I'm curious: why wasn't this discovered before now?

@shamisp
Copy link
Contributor Author

shamisp commented Jun 27, 2016

@jsquyres The bug can be exposed with any SHMEM code running on NP > 2. So I suspect nobody is really testing the code with more than two processes.

@jladd-mlnx jladd-mlnx merged commit 5795682 into open-mpi:master Jun 27, 2016
@jsquyres
Copy link
Member

jsquyres commented Jun 27, 2016

Is there going to be a v2.0.0 PR for this? If so, please file it ASAP.

@hppritcha
Copy link
Member

hppritcha commented Jun 28, 2016

It does appear the same problem exists on 2x.

@shamisp
Copy link
Contributor Author

shamisp commented Jun 28, 2016

I will prepare the patch.

On Tue, Jun 28, 2016 at 9:05 AM, Howard Pritchard notifications@github.com
wrote:

It does appear the same problem exists on 2x.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1817 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ACIe2NAx2iDZuj3s_TY0sJsB4jBMPmX-ks5qQSo9gaJpZM4I-KYi
.

@shamisp shamisp mentioned this pull request Jun 28, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Severity: blocker

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shamisp @jsquyres @hppritcha @jladd-mlnx