Skip to content

ucx: adapt pml_ucx and spml_ucx to new UCX APIs #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2016
Merged

ucx: adapt pml_ucx and spml_ucx to new UCX APIs #2222

merged 2 commits into from
Oct 18, 2016

Conversation

@yosefe
Copy link
Contributor

@yosefe yosefe commented Oct 13, 2016 •
edited
Loading

picked from #2218

  • pass field_mask to ucp_init().
  • use non-blocking disconnect.
  • recv() with pre-allocated request.
  • call opal_progress() from iprobe() and improbe().
  • use shift pattern in connect/disconnect.

@yosefe
ucx: adapt pml_ucx and spml_ucx to new UCX APIs
73e828c 
- pass field_mask to ucp_init().
- use non-blocking disconnect.
- recv() with pre-allocated request.
- call opal_progress() from iprobe() and improbe().
- use shift pattern in connect/disconnect.
@yosefe yosefe added this to the v2.1.0 milestone Oct 13, 2016
@yosefe
Copy link
Contributor Author

yosefe commented Oct 13, 2016

@jladd-mlnx @miked-mellanox

@mike-dubman
Copy link
Member

mike-dubman commented Oct 13, 2016

👍

1 similar comment
@jladd-mlnx
Copy link
Member

jladd-mlnx commented Oct 13, 2016

👍

@jsquyres
Copy link
Member

jsquyres commented Oct 15, 2016

bot:lanl:retest

alinask
alinask reviewed Oct 16, 2016
View reviewed changes
ompi/mca/pml/ucx/pml_ucx_component.c Outdated

ompi_pml_ucx.num_disconnect = 1;
(void) mca_base_component_var_register(&mca_pml_ucx_component.pmlm_version, "num_disconnect",
"How may disconnects go in parallel",
Copy link
Member

@alinask alinask Oct 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"How many..."
(typo)

@yosefe
Copy link
Contributor Author

yosefe commented Oct 16, 2016

@alinask thanks, fixed

@hppritcha
Copy link
Member

hppritcha commented Oct 17, 2016

Is this PR needed at least partly because there was a change in the UCX API?

@yosefe
Copy link
Contributor Author

yosefe commented Oct 18, 2016 •
edited
Loading

@hppritcha yes, there were some additions to UCX API, some of them were needed to fix bugs (errors during disconnect), others are optimization and enabling forward compatibility.

@jsquyres jsquyres merged commit d2f0757 into open-mpi:v2.x Oct 18, 2016
@yosefe yosefe deleted the topic/ucx-pml-spml-update-for-v2.x branch October 18, 2016 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hppritcha hppritcha hppritcha approved these changes

+2 more reviewers

@alinask alinask alinask left review comments

@mike-dubman mike-dubman mike-dubman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hppritcha hppritcha

Labels

enhancement RM approved Target: v2.x

Projects

None yet

Milestone

v2.1.0

Development

Successfully merging this pull request may close these issues.

6 participants

@yosefe @mike-dubman @jladd-mlnx @jsquyres @hppritcha @alinask