-
Notifications
You must be signed in to change notification settings - Fork 932
v2.x: pmix: fix PMIx_server_register_nspace() usage #2885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp> (cherry picked from commit open-mpi/ompi@ef10d3f)
PMIx_server_register_nspace() is an asynchronous operation, so the pmix glue wait for it completes before returning. Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp> (back-ported from commit open-mpi/ompi@dccb189)
PMIx_server_register_nspace() is an asynchronous operation, so the pmix glue wait for it completes before returning. Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp> (back-ported from commit open-mpi/ompi@dccb189)
rhc54
approved these changes
Jan 31, 2017
Contributor
Author
|
:bot:lanl:retest |
Member
|
We have a regression with --disable-open on v2.x |
Contributor
Author
|
@hppritcha is it a really a regression or a jenkins issue ?
that suggests the working directory is not empty when Jenkins starts building a PR since i cannot make any sense of this error, i am thinking the root cause could be some leftover in Jenkins. |
Member
|
bot:lanl:retest |
karasevb
added a commit
to karasevb/ompi
that referenced
this pull request
Feb 15, 2017
This bug introduced in PR open-mpi#2885. The status variable of waiting was not initialized it leads to early data release and memory corruption. Signed-off-by: Boris Karasev <karasev.b@gmail.com>
karasevb
added a commit
to karasevb/ompi
that referenced
this pull request
Feb 15, 2017
This bug introduced in PR open-mpi#2885. The status variable of waiting was not initialized it leads to early release of the callback data and memory corruption. Signed-off-by: Boris Karasev <karasev.b@gmail.com>
karasevb
added a commit
to karasevb/ompi
that referenced
this pull request
Feb 15, 2017
This bug introduced in PR open-mpi#2885. The status variable of waiting was not activated it leads to early release of the callback data and memory corruption. Signed-off-by: Boris Karasev <karasev.b@gmail.com>
karasevb
added a commit
to karasevb/ompi
that referenced
this pull request
Feb 15, 2017
This bug introduced in PR open-mpi#2885. The status variable of waiting was not activated it leads to early release of the callback data and memory corruption. Signed-off-by: Boris Karasev <karasev.b@gmail.com>
karasevb
added a commit
to karasevb/ompi
that referenced
this pull request
Feb 15, 2017
This bug introduced in PR open-mpi#2885. The status variable of waiting was not activated it leads to early release of the callback data and memory corruption. Signed-off-by: Boris Karasev <karasev.b@gmail.com>
karasevb
added a commit
to karasevb/ompi
that referenced
this pull request
Feb 15, 2017
Corresponds to PR open-mpi#2981 This bug introduced in PR open-mpi#2885. The status variable of waiting was not activated it leads to early release of the callback data and memory corruption. Signed-off-by: Boris Karasev <karasev.b@gmail.com> (cherry picked from commit 179abe4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.