pmix/external: Fix memory corruption #2983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corresponds to PR open-mpi#2981 This bug introduced in PR open-mpi#2885. The status variable of waiting was not activated it leads to early release of the callback data and memory corruption. Signed-off-by: Boris Karasev <karasev.b@gmail.com> (cherry picked from commit 179abe4)
Contributor
|
I'm missing something here - this only addresses the external pmix component. The referenced PR went into a different branch (v2.x) and touched both the external and internal glue code. Don't we need both here? |
Contributor
|
Never mind - I see what happened. He just missed initializing the variable in one of the files, but did it for the other. Kewl. |
Contributor
|
yep, i missed it when backporting from master/pmix1x into v2/external |
artpol84
approved these changes
Feb 15, 2017
Member
|
@ggouaillardet can you give the thumbs up on this one? |
ggouaillardet
approved these changes
Feb 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponds to PR #2981
This bug introduced in PR #2885. The status variable of waiting was not
activated it leads to early release of the callback data and memory
corruption.
Signed-off-by: Boris Karasev karasev.b@gmail.com
(cherry picked from commit 179abe4)