OSHMEM/CONFIGURE: Check for the presence of ibv_exp_reg_shared_mr. #4315
Conversation
|
@yosefe @miked-mellanox @alex-mikheev @jladd-mlnx Please review. |
oshmem/mca/sshmem/verbs/configure.m4
Outdated
| ibv_exp_reg_shared_mr(&in_smr); | ||
| ]])], | ||
| [oshmem_have_exp_reg_shared_mr=1], | ||
| [oshmem_have_exp_reg_shared_mr=0]) |
There was a problem hiding this comment.
can we set oshmem_verbs_sm_build_verbs=0 directly from here?
There was a problem hiding this comment.
yes, but this is how it is also done in the next check in this file so i kept the consistency
oshmem/mca/sshmem/verbs/configure.m4
Outdated
| AS_IF( | ||
| [test "$oshmem_verbs_sm_build_verbs" = "1"], | ||
| [ | ||
| OSHMEM_LIBSHMEM_EXTRA_LDFLAGS="$OSHMEM_LIBSHMEM_EXTRA_LDFLAGS $oshmem_verbs_LDFLAGS" |
There was a problem hiding this comment.
why is it needed to set these variables?
oshmem/mca/sshmem/verbs/configure.m4
Outdated
| AC_SUBST([oshmem_verbs_LDFLAGS]) | ||
| AC_SUBST([oshmem_verbs_LIBS]) | ||
|
|
||
| oshmem_have_exp_reg_shared_mr=0 |
There was a problem hiding this comment.
looking at the m4 file, seems like this check(AC_COMPILE_IFELSE) should replace these lines:
AC_CHECK_DECLS([IBV_EXP_ACCESS_ALLOCATE_MR,IBV_EXP_ACCESS_SHARED_MR_USER_READ],
[oshmem_have_mpage=3], [],
[#include <infiniband/verbs.h>])
because it's also possible that the "old" API of shared_mr is supported (oshmem_have_mpage=2) and then no need to disable the verbs component
|
had to kill off armv8 testing. |
alinask
force-pushed
the
topic/oshmem_config_ibv_exp_reg_shared_mr
branch
from
0286acc to
4dcc85b
Compare
|
@yosefe updated. |
oshmem/mca/sshmem/verbs/configure.m4
Outdated
| AS_IF([test "$oshmem_have_mpage" = "3"], | ||
| [ | ||
| oshmem_verbs_save_CFLAGS="$CFLAGS" | ||
| CFLAGS="$CFLAGS $oshmem_verbs_save_CFLAGS -Wno-strict-prototypes -Werror" |
There was a problem hiding this comment.
no need to add $oshmem_verbs_save_CFLAGS
oshmem/mca/sshmem/verbs/configure.m4
Outdated
| in_smr.exp_access = access_flags; | ||
| ibv_exp_reg_shared_mr(&in_smr); | ||
| ]])], | ||
| [oshmem_verbs_sm_build_verbs=1], |
There was a problem hiding this comment.
no need to set oshmem_verbs_sm_build_verbs=1 here, just set it to 0 in the 'else' case
+ The sshmem verbs component will disqualify itself if this verb isn't present on the build host. + In case where support was requested but not found, don't stop the build - continue without this component. Signed-off-by: Alina Sklarevich <alinas@mellanox.com>
alinask
force-pushed
the
topic/oshmem_config_ibv_exp_reg_shared_mr
branch
from
4dcc85b to
3008827
Compare
|
@yosefe updated, please review |
3 participants
present on the build host.
build - continue without this component.
Signed-off-by: Alina Sklarevich alinas@mellanox.com