Skip to content

dist: Update .so version numbers for v3.1.0 #4838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2018
Merged

dist: Update .so version numbers for v3.1.0 #4838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,32 +84,32 @@ date="Unreleased developer copy"
# Version numbers are described in the Libtool current:revision:age
# format.

libmpi_so_version=0:0:0
libmpi_cxx_so_version=0:0:0
libmpi_mpifh_so_version=0:0:0
libmpi_usempi_tkr_so_version=0:0:0
libmpi_usempi_ignore_tkr_so_version=0:0:0
libmpi_usempif08_so_version=0:0:0
libopen_rte_so_version=0:0:0
libopen_pal_so_version=0:0:0
libmpi_java_so_version=0:0:0
liboshmem_so_version=0:0:0
libompitrace_so_version=0:0:0
libmpi_so_version=50:0:10
libmpi_cxx_so_version=50:0:10
libmpi_mpifh_so_version=50:0:10
libmpi_usempi_tkr_so_version=50:0:10
libmpi_usempi_ignore_tkr_so_version=50:0:10
libmpi_usempif08_so_version=50:0:10
libopen_rte_so_version=50:0:10
libopen_pal_so_version=50:0:10
libmpi_java_so_version=50:0:10
liboshmem_so_version=50:0:10
libompitrace_so_version=50:0:10

# "Common" components install standalone libraries that are run-time
# linked by one or more components. So they need to be versioned as
# well. Yuck; this somewhat breaks the
# components-don't-affect-the-build-system abstraction.

# OMPI layer
libmca_ompi_common_ompio_so_version=0:0:0
libmca_ompi_common_ompio_so_version=50:0:9
Copy link
Member

@jsquyres jsquyres Feb 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bwbarrett Why on earth did we make OMPI's C value be 41 in v3.0.0? 😱 (this is just a rhetorical question)

Also, I notice that ompi/mca/common/monitoring has no version number here. Indeed, it doesn't look like it is versioned at all, which seems problematic.

This PR should still go through, but I think we need another PR that adds a version number for the common monitoring library.

Copy link
Member Author

@bwbarrett bwbarrett Feb 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't; see the commit comment. There was a backwards-incompatible change in common_ompio in 3.0.1. 3.1 includes that change, so it should only be backwards compatible to 3.0.1, not 3.0.0 (well, the shared libraries built by those versions, but you know what I mean).

Good catch on the monitoring change; thanks for making that.


# ORTE layer
libmca_orte_common_alps_so_version=0:0:0
libmca_orte_common_alps_so_version=50:0:10

# OPAL layer
libmca_opal_common_cuda_so_version=0:0:0
libmca_opal_common_ofi_so_version=0:0:0
libmca_opal_common_sm_so_version=0:0:0
libmca_opal_common_ugni_so_version=0:0:0
libmca_opal_common_verbs_so_version=0:0:0
libmca_opal_common_cuda_so_version=50:0:10
libmca_opal_common_ofi_so_version=50:0:10
libmca_opal_common_sm_so_version=50:0:10
libmca_opal_common_ugni_so_version=50:0:10
libmca_opal_common_verbs_so_version=50:0:10