dist: Update .so version numbers for v3.1.0 #4838
Conversation
Update the shared library version numbers for v3.1.0. As a ABI compatible version with the v3.0.x series, follow our convention of bumping the current number by 10 and setting the age to v3.0.0 age + 10. There is one exception to that rule, as libmca_ompi_common_ompio was changed in an incompatible way in v3.0.1 (v3.1.x includes that change), so we are only backwards compatible to that version, not all the way to v3.0.0. Since ompi_common isn't part of the stable ABI and users would have to do something really weird to even hit that case, this isn't too big of a deal. Signed-off-by: Brian Barrett <bbarrett@amazon.com>
|
|
||
| # OMPI layer | ||
| libmca_ompi_common_ompio_so_version=0:0:0 | ||
| libmca_ompi_common_ompio_so_version=50:0:9 |
There was a problem hiding this comment.
@bwbarrett Why on earth did we make OMPI's C value be 41 in v3.0.0? 😱 (this is just a rhetorical question)
Also, I notice that ompi/mca/common/monitoring has no version number here. Indeed, it doesn't look like it is versioned at all, which seems problematic.
This PR should still go through, but I think we need another PR that adds a version number for the common monitoring library.
There was a problem hiding this comment.
We didn't; see the commit comment. There was a backwards-incompatible change in common_ompio in 3.0.1. 3.1 includes that change, so it should only be backwards compatible to 3.0.1, not 3.0.0 (well, the shared libraries built by those versions, but you know what I mean).
Good catch on the monitoring change; thanks for making that.
2 participants
Update the shared library version numbers for v3.1.0. As a
ABI compatible version with the v3.0.x series, follow our
convention of bumping the current number by 10 and setting the
age to v3.0.0 age + 10. There is one exception to that rule,
as libmca_ompi_common_ompio was changed in an incompatible
way in v3.0.1 (v3.1.x includes that change), so we are only
backwards compatible to that version, not all the way to
v3.0.0. Since ompi_common isn't part of the stable ABI and
users would have to do something really weird to even hit
that case, this isn't too big of a deal.
Signed-off-by: Brian Barrett bbarrett@amazon.com