configure: remove POWER 7/BE block #5034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We thought there was a silent data corruption issue on POWER 7/BE systems, so we blocked building on POWER 7/BE systems altogether. We later figured out that it was just data hangs -- not silent data corruption. So in hindsight, the configure block probably wasn't necessary -- but we didn't know it at the time. Regardless, the hangs have now been fixed, and we're removing the POWER 7/BE block in configure. For more detail on the entire saga, see open-mpi#4349 (comment). Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
This is a separate commit from the commit where the block was removed from configure.ac because this NEWS bullet will almost certainly not cherry-pick cleanly to release branches. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
jjhursey
approved these changes
Apr 6, 2018
Member
jjhursey
left a comment
jjhursey
left a comment
There was a problem hiding this comment.
This will remove the PPC 7/BE block. 👍
Member
|
Ref PR #4090 |
Member
Author
|
It looks like the README already says that POWER 7/BE may hang. So we might as well merge now (i.e., since we finally remembered that this POWER 7/BE issue is not silent data corruption, we can remove the drastic step of prohibiting POWER 7/BE builds altogether). I.e., it's taking @hjelmn longer than anticipated to fix #4563 -- but we really don't need to wait for that to remove the POWER 7/BE configure block. So let's merge now. |
This was referenced Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge until #4563 is fixed.
Fixes #5032.
This will need to be cherry-picked to v2.x, v3.0.x, and v3.1.x. Let's hope this his master before we branch for v4.0.x, but if it doesn't, it will need to be cherry-picked there, too.
Note that there's 2 commits on this PR: one that removes the block (and is easily cherry-picked) and another that contains the NEWS update (that almost certainly will not cherry-pick to the release branches properly).