v3.0.x: remove power7be configure block #5051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We thought there was a silent data corruption issue on POWER 7/BE systems, so we blocked building on POWER 7/BE systems altogether. We later figured out that it was just data hangs -- not silent data corruption. So in hindsight, the configure block probably wasn't necessary -- but we didn't know it at the time. Regardless, the hangs have now been fixed, and we're removing the POWER 7/BE block in configure. For more detail on the entire saga, see open-mpi#4349 (comment). Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 3f0ccff)
Also note that ARM and POWER users may experience hangs (until open-mpi#4563 is fixed). Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
jjhursey
reviewed
Apr 10, 2018
Member
jjhursey
left a comment
jjhursey
left a comment
There was a problem hiding this comment.
The other PRs had a change to the README - https://github.com/open-mpi/ompi/pull/5052/files#diff-c47c7c7383225ab55ff591cb59c41e6b - is that needed on this branch too?
Member
Author
|
@jjhursey No; that blurb already exists here in the v3.0.x README. |
jjhursey
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #5034 and larger discussion on #4349.
Still waiting for #4563 to be fixed (to resolve hangs on some ARM/POWER platforms), but that's a different issue.