Skip to content

Conversation

@hoopoepg
Copy link
Contributor

@hoopoepg hoopoepg commented Jun 8, 2018

fixes issue openucx/ucx#2656

added flush for worker object to complete all pending operations

cherry picked from #5227, commit 0a8261f

Signed-off-by: Sergey Oblomov sergeyo@mellanox.com

@jsquyres
Copy link
Member

jsquyres commented Jun 8, 2018

@hoopoepg Is this a cherry pick from master? Or is this unique to v3.1? If it's a cherry pick from master, please be sure to use git cherry-pick -x ... so that git automatically puts in the "(cherry picked from ..." tagline in the commit message.

In general, we usually commit fixes to master first and then file PRs that are cherry picks from master to the release branches -- unless there's a fix specific to a release branch (and not relevant to master), of course. But then we specifically note that in the PR so that reviewers aren't surprised.

@hoopoepg hoopoepg force-pushed the topic/pml-ucx-hang-on-finalize-v3.1 branch from 855d6a2 to ae1a54d Compare June 8, 2018 13:23
fixes issue openucx/ucx#2656

added flush for worker object to complete all pending operations

Signed-off-by: Sergey Oblomov <sergeyo@mellanox.com>
(cherry picked from commit 0a8261f)
@hoopoepg hoopoepg force-pushed the topic/pml-ucx-hang-on-finalize-v3.1 branch from ae1a54d to 923e159 Compare June 8, 2018 13:24
@hoopoepg
Copy link
Contributor Author

hoopoepg commented Jun 8, 2018

@jsquyres yep, sorry, forgot to note about cherry-pick
updated commit and and PR messages

@jsquyres
Copy link
Member

jsquyres commented Jun 8, 2018

Ok, thanks. Does it need to go to v3.0.x as well?

@hoopoepg
Copy link
Contributor Author

hoopoepg commented Jun 8, 2018

I think yes, it seems this is long-play issue
@yosefe back-port it to v3.0?

@yosefe
Copy link
Contributor

yosefe commented Jun 8, 2018

yes

@yosefe yosefe added the bug label Jun 8, 2018
- added debug output for woker flush failure

Signed-off-by: Sergey Oblomov <sergeyo@mellanox.com>
(cherry picked from commit c3dbc86)
@alinask
Copy link
Member

alinask commented Jun 10, 2018

bot:mellanox:retest

@alinask alinask changed the title PML/UCX: fixed hand on MPI_Finalize - v3.1.x PML/UCX: fixed hang on MPI_Finalize - v3.1.x Jun 11, 2018
@alinask
Copy link
Member

alinask commented Jun 11, 2018

@bwbarrett @jsquyres Can you please merge this PR?

@alinask alinask added this to the v3.1.1 milestone Jun 12, 2018
@bwbarrett bwbarrett merged commit ed81a13 into open-mpi:v3.1.x Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants