Skip to content

PML/UCX: fixed hang on MPI_Finalize - v3.0 #5257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2018
Merged

PML/UCX: fixed hang on MPI_Finalize - v3.0 #5257

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0baed6
PML/UCX: fixed hand on MPI_Finalize
Jun 5, 2018
4613d53
PML/UCX: suppressed coverity issue
Jun 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ompi/mca/pml/ucx/pml_ucx.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,7 @@ int mca_pml_ucx_del_procs(struct ompi_proc_t **procs, size_t nprocs)
void *dreq, **dreqs;
ucp_ep_h ep;
size_t i;
ucs_status_t ret;

max_reqs = ompi_pml_ucx.num_disconnect;
if (max_reqs > nprocs) {
Expand Down Expand Up @@ -429,6 +430,14 @@ int mca_pml_ucx_del_procs(struct ompi_proc_t **procs, size_t nprocs)

mca_pml_ucx_waitall(dreqs, &num_reqs);
free(dreqs);
/* flush worker to allow all pending operations to complete.
* ignore error (we can do nothing here), just try to
* finalize gracefully */
ret = ucp_worker_flush(ompi_pml_ucx.ucp_worker);
if (UCS_OK != ret) {
PML_UCX_ERROR("ucp_worker_flush failed: %s",
ucs_status_string(ret));
}

opal_pmix.fence(NULL, 0);

Expand Down