PML/UCX: fixed hang on MPI_Finalize - v3.0 #5257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes issue openucx/ucx#2656 added flush for worker object to complete all pending operations Signed-off-by: Sergey Oblomov <sergeyo@mellanox.com> (cherry picked from commit 0a8261f)
|
@hoopoepg let's also add the coverity fix here (check return value) |
- added debug output for woker flush failure Signed-off-by: Sergey Oblomov <sergeyo@mellanox.com> (cherry picked from commit c3dbc86)
|
@yosefe done |
|
@yosefe btw, update v3.1 too? |
|
@hoopoepg yes |
|
bot:mellanox:retest |
alinask
changed the title
|
@bwbarrett Can you please merge this PR? |
|
@alex-mikheev @karasevb @yosefe @hoopoepg Someone needs to review it. |
yosefe
approved these changes
Jun 12, 2018
|
@jsquyres Is this good to go? |
|
PR's for release branches need to also assign labels and milestones -- otherwise the RMs for those release branches won't see them. https://github.com/open-mpi/ompi/wiki/SubmittingPullRequests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue openucx/ucx#2656
added flush for worker object to complete all pending operations
picked from #5227
Signed-off-by: Sergey Oblomov sergeyo@mellanox.com
(cherry picked from commit 0a8261f)