UCX: added missing UCX libs to UCX detection - v3.0 #5679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpaulsen
approved these changes
Sep 12, 2018
Member
|
retest |
Member
|
:retest:osx: |
Member
|
bot:retest:osx |
gpaulsen
previously requested changes
Sep 12, 2018
Member
gpaulsen
left a comment
gpaulsen
left a comment
There was a problem hiding this comment.
I just noticed that the cherry-picked from line
mentions only the first commit in the master PR, but not the second: 0xe735593.
Please cherry-pick the second-commit as well into v4.0.x
added 2 commits
September 12, 2018 19:47
hoopoepg
force-pushed
the
topic/missing-ucp-deps-v3.0
branch
from
a98349f to
6629313
Compare
Contributor
Author
|
bot:retest |
Member
|
@gpaulsen can you re-review? |
gpaulsen
approved these changes
Sep 24, 2018
Contributor
|
@gpaulsen @bwbarrett ok to merge? |
Member
|
@yosefe @hoopoepg Please be sure to set the right meta data on PRs. The title, branch, and label all indicate 3.0, but the milestone is set for v3.1. I'll fix the milestone. Also note that the RM for 3.0 is @bwbarrett. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport from #5666
Signed-off-by: Sergey Oblomov sergeyo@mellanox.com
(cherry picked from commit c982645)