IKRIT: restored compilation - v4.0 #7002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- due to some refactoring and adding new functionality compilation of ikrit module was broken - this commit restores compilation Signed-off-by: Sergey Oblomov <sergeyo@mellanox.com> (cherry picked from commit 991082a)
yosefe
approved these changes
Sep 23, 2019
hoopoepg
changed the title
jsquyres
reviewed
Sep 23, 2019
| #define MEMHEAP_BASE_PAGE_ORDER 21 | ||
| #define MEMHEAP_BASE_PRIVATE_SIZE (1ULL << MEMHEAP_BASE_PAGE_ORDER) /* should be at least the same as a huge page size */ | ||
| #define MEMHEAP_BASE_MIN_SIZE (1ULL << MEMHEAP_BASE_PAGE_ORDER) /* must fit into at least one huge page */ | ||
| #define MEMHEAP_BASE_MIN_SIZE (1ULL << MEMHEAP_BASE_PAGE_ORDER) /* must fit into at least one huge page */ |
Member
There was a problem hiding this comment.
I realize that this is a cherry-pick from master and therefore we can't really fix this here, but can you please try to avoid spurious whitespace changes in commits that contain code/logic changes in the future?
Whitespace-only changes are fine, but please fix those in a separate commit that has no other code/logic changes. Doing it this way just makes it easier to see code/logic fixes (which is the important stuff).
Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of ikrit module was broken
backport from #6979
Signed-off-by: Sergey Oblomov sergeyo@mellanox.com
(cherry picked from commit 991082a)