Topic/btl uct fixes for v4.0.x #7152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenUCX broke the UCT API again in v1.8. This commit updates btl/uct to fix compilation with current OpenUCX master (future v1.8). Further changes will likely be needed for the final release. Signed-off-by: Nathan Hjelm <hjelmn@google.com> (cherry picked from commit 526775d)
Ref open-mpi#7128 Signed-off-by: Nathan Hjelm <hjelmn@google.com> (cherry picked from commit a3026c0)
related to open-mpi#7128 The UCX crew is no longer guaranteeing that the UCT API is going to be frozen, so this is kind of a whack-a-mole problem trying to keep the BTL UCT working with various changing UCT APIs. Signed-off-by: Howard Pritchard <howardp@lanl.gov> (cherry picked from commit 9d345d9)
|
While the commits in the PR claim to fix UCT/BTL for both v1.7 and v1.8, note that the configury in this PR will only attempt to biuld UCT/BTL for versions up to v1.7 (not v1.8). The rational for that being UCX v1.8 still hasn't released, and is just master in the UCX project, and may still need additional changes. |
gpaulsen
approved these changes
Nov 8, 2019
|
@yosefe what is the schedule for the UCX 1.7 release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
three BTL UCT commits cherry-picked from master:
9d345d9
a3026c0
526775d
we fix the whitelisted UCX/UCT to 1.7 since "1.8" is really UCX master for which the UCT API could still be in flux.